[#45520] - [5.3] Installation missing string
- Fixed in Code Base
- 27 May 2025
- Medium
- Build: 5.3-dev
- # 45520
- Diff
- brianteeman:missing_close
User tests: Successful: Unsuccessful:
@chmst identified in #45429 that the close button in the dialog was not being translated. This was because the language string JCLOSE was not present in the installation language files.
Technically core does not need this string to be added until j6 where it is used in the installation dialog but I dont see any harm in adding it now as it is possible that someone adds a dialog in upcoming 5.x releases
Testing either by code review or by following the original text instructions for the dialog element in #40150 making sure you are editing an installation template file
Link to documentations
Please select:
-
Documentation link for docs.joomla.org:
-
No documentation changes for docs.joomla.org needed
-
Pull Request link for manual.joomla.org:
-
No documentation changes for manual.joomla.org needed
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | Installation Language & Strings |
I have tested this item ✅ successfully on 8b24fd7
Tested by code review.
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/45520.
| Status | Pending | ⇒ | Ready to Commit |
| Labels |
Added:
Language Change
PR-5.3-dev
|
||
RTC
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/45520.
| Status | Ready to Commit | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2025-05-27 22:23:11 |
| Closed_By | ⇒ | bembelimen | |
| Labels |
Added:
RTC
|
||
Thx
Thanks
I have tested this item ✅ successfully on 8b24fd7
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/45520.