[#45521] - [6.0] Improve ListView toolbar & components
- Fixed in Code Base
- 16 Aug 2025
- Medium
- Build: 6.0-dev
- # 45521
- Diff
- bembelimen:6.0/toolbar-buttons
User tests: Successful: Unsuccessful:
Pull Request for Issue # .
Summary of Changes
This PR enhances the ListView class to:
- have the modern toolbar respecting all the permissions
- handle errors in a way, that the view does not crash
- handle empty list behaviour
It updates the following core views:
- ActionLogs view
- Banners view
- Contacts view
- Modules view
as they're very straight forward
Testing Instructions
For testing this you have to check the 4 views mentioned above. It's important to play around with the component permission, e.g. remove "create" permissions and see if in old and in new the same buttons are visible.
Also test with super user account and without if the buttons of the components are still the same with the same behaviour.
Also delete all the items in the component to see, that the empty state behaviour is the same.
Expected result AFTER applying this Pull Request
Toolbars behaves the same
Link to documentations
Please select:
-
Documentation link for docs.joomla.org:
-
No documentation changes for docs.joomla.org needed
-
Pull Request link for manual.joomla.org:
-
No documentation changes for manual.joomla.org needed
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | Administration com_banners com_contact com_modules Libraries |
| Labels |
Added:
Feature
PR-6.0-dev
|
||
@exlemor the problems were the conflicts, I fixed them and you can test again please. Thank you, really appreciate it.
Hi @bembelimen, Benjamin,
When I try to turn on the PR via Patch Tester, I get this error message in Red:
The file marked for modification does not exist: phpstan-baseline.neon
Trying to apply it to a nightly of "6.0.0-alpha4-dev", I installed yesterday.
:( (sorry)
I have tested this item ✅ successfully on 9673cb8
I have tested this successfully - thanks for the hard word and the fixes @bembelimen!
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/45521.
I have tested this item ✅ successfully on 9673cb8
Tested 4 views across 3 users with diff perms. I couldn't break it but learned a ton about permissions.
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/45521.
| Status | Pending | ⇒ | Ready to Commit |
RTC
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/45521.
| Labels |
Added:
RTC
|
||
| Status | Ready to Commit | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2025-08-16 13:51:22 |
| Closed_By | ⇒ | softforge |
Thank you for your work on this @bembelimen and the testers
@bembelimen, I wish I had good news...
When the PR is applied (6.0 nightly from this afternoon), the New and Actions button are NON functional on Banners, Contacts, Modules, ... yet if remove the Patch, they work perfectly fine... ;(
(for the ActionsLog, the Delete buttons are clickable and the Warning window appears but it doesn't actually delete entries :/
Console: (could be cumulative errors from the Banners, Contacts, Modules screens to be clear)
)
(sorry)