RMDQ PR-5.3-dev Pending

User tests: Successful: Unsuccessful:

avatar pe7er
pe7er
20 May 2025

Same issue as #45501, #45502 and #45503 but with Menu Titles and Menu Item Titles

Summary of Changes

This PR removes the spaces before and after the Menu Titles and Menu Item Titles.

Testing Instructions

In back-end: Menus > Manage > edit Main Menu, add spaces and save

In back-end: Menus > Main Menu > edit menu item, e.g. Home, add a lot of spaces and save

Actual result BEFORE applying this Pull Request

Menu edit
menu-edit-before-pr

Menu Item edit
menu-title-before-pr

Expected result AFTER applying this Pull Request

Menu edit
menu-after-pr

Menu Item edit
menu-title-after-pr

Link to documentations

Please select:

  • Documentation link for docs.joomla.org:

  • No documentation changes for docs.joomla.org needed

  • Pull Request link for manual.joomla.org:

  • No documentation changes for manual.joomla.org needed

avatar pe7er pe7er - open - 20 May 2025
avatar pe7er pe7er - change - 20 May 2025
Status New Pending
avatar joomla-cms-bot joomla-cms-bot - change - 20 May 2025
Category Administration com_menus
avatar exlemor exlemor - test_item - 20 May 2025 - Tested successfully
avatar exlemor
exlemor - comment - 20 May 2025

I have tested this item ✅ successfully on 29364be

I have tested this successfully. Thanks pe7er.


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/45504.

avatar krishnaGandhi11
krishnaGandhi11 - comment - 23 May 2025

I found a crash while testing this PR.
Attaching a video to show it:

PR_45504_test.mp4
avatar brianteeman
brianteeman - comment - 23 May 2025

@exlemor please retest as there is no way your first test could have been successful

avatar exlemor exlemor - alter_testresult - 23 May 2025 - exlemor: Not tested
avatar exlemor
exlemor - comment - 23 May 2025

Yes @brianteeman, I missed a step :( and only tested after applying the PR the Menus > Main Menu > edit menu item, and not the Menu title as well ;( I apologize for the misstep. When Krishna showed me his test, I told him to post it (I was going to retest it but you beat me to it ;) )


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/45504.

I get the same result as he does for the Menu title.

avatar QuyTon QuyTon - change - 23 May 2025
Labels Added: PR-5.3-dev
avatar QuyTon
QuyTon - comment - 23 May 2025

Fixed. Please retest. Thank you!

avatar ceford ceford - test_item - 24 May 2025 - Tested successfully
avatar ceford
ceford - comment - 24 May 2025

I have tested this item ✅ successfully on 1479b56


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/45504.

avatar webmasterab webmasterab - test_item - 25 May 2025 - Tested successfully
avatar webmasterab
webmasterab - comment - 25 May 2025

I have tested this item ✅ successfully on 1479b56

I have tested this successfully.


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/45504.

avatar HLeithner HLeithner - change - 4 Jun 2025
Status Pending Closed
Closed_Date 0000-00-00 00:00:00 2025-06-04 18:21:17
Closed_By HLeithner
Labels Added: RMDQ
avatar HLeithner HLeithner - close - 4 Jun 2025
avatar HLeithner
HLeithner - comment - 4 Jun 2025

Hi @pe7er

thanks for the PR but we discussed this now several times in maintainers channel and come to the following conclusion:

  1. Fedir mentioned in comment that this would prevent our default filter
  2. We shouldn't touch user input if not really needed.

So I'm closing this PR.

Add a Comment

Login with GitHub to post a comment