Joomla! Issue Tracker - CMS

Download
Launch
Feeling Lucky

[#45503] - [5.3] Module Titles - Remove spaces before and after title

RMDQ PR-5.3-dev Pending

User tests: Successful: Unsuccessful:

avatar pe7er
pe7er
20 May 2025

Same issue as #45501 and #45502 but with Site and Admin Modules

Summary of Changes

This PR trims the spaces before and after the titles of Site and Admin Modules.

Testing Instructions

In the back-end open a Site Module, add a lot of spaces before the title, and save.
In the back-end open an Admin Module, add a lot of spaces before the title, and save.

Actual result BEFORE applying this Pull Request

Site Module with a lot of spaces after save:

site-module-before-pr

Admin Module with a lot of spaces after save:

admin-module-before-pr

Expected result AFTER applying this Pull Request

Site Module with a lot of spaces after save. The spaces before and after the title are removed:

module-site-after-pr

Admin Module with a lot of spaces after save. The spaces before and after the title are removed:

module-admin-after-pr

Link to documentations

Please select:

  • Documentation link for docs.joomla.org:

  • No documentation changes for docs.joomla.org needed

  • Pull Request link for manual.joomla.org:

  • No documentation changes for manual.joomla.org needed

avatar pe7er pe7er - open - 20 May 2025
avatar pe7er pe7er - change - 20 May 2025
Status New ⇒ Pending
avatar joomla-cms-bot joomla-cms-bot - change - 20 May 2025
Category ⇒ Administration com_modules
avatar exlemor exlemor - test_item - 20 May 2025 - Tested successfully
avatar exlemor
exlemor - comment - 20 May 2025

I have tested this item ✅ successfully on ddf926b

I have tested this successfully. Thanks pe7er.

This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/45503.

avatar krishnaGandhi11 krishnaGandhi11 - test_item - 23 May 2025 - Tested successfully
avatar krishnaGandhi11
krishnaGandhi11 - comment - 23 May 2025

I have tested this item ✅ successfully on ddf926b

Tested Successfully, works as expected! (Thanks for detailed test instructions)

This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/45503.

avatar QuyTon QuyTon - change - 23 May 2025
Status Pending ⇒ Ready to Commit
Labels Added: PR-5.3-dev
avatar QuyTon
QuyTon - comment - 23 May 2025

RTC

This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/45503.

avatar Fedik Fedik - change - 25 May 2025
Status Ready to Commit ⇒ Pending
avatar Fedik
Fedik - comment - 25 May 2025

Same as #45501 (comment)

This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/45503.

avatar webmasterab webmasterab - test_item - 25 May 2025 - Tested successfully
avatar webmasterab
webmasterab - comment - 25 May 2025

I have tested this item ✅ successfully on ddf926b

Tested Successfully, works as expected! (Thanks for detailed test instructions)

This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/45503.

avatar HLeithner HLeithner - change - 4 Jun 2025
Status Pending ⇒ Closed
Closed_Date 0000-00-00 00:00:00 ⇒ 2025-06-04 18:21:20
Closed_By ⇒ HLeithner
Labels Added: RMDQ
avatar HLeithner HLeithner - close - 4 Jun 2025
avatar HLeithner
HLeithner - comment - 4 Jun 2025

Hi @pe7er

thanks for the PR but we discussed this now several times in maintainers channel and come to the following conclusion:

  1. Fedir mentioned in comment that this would prevent our default filter
  2. We shouldn't touch user input if not really needed.

So I'm closing this PR.

Add a Comment

Login with GitHub to post a comment