RMDQ PR-5.3-dev Pending

User tests: Successful: Unsuccessful:

avatar pe7er
pe7er
20 May 2025

Same issue as #45501, #45502, #45503 and #45504 but with Users, Groups, User Notes.
Access Levels does not have this issue: spaces before or after the Access level title are removed during saving.

Summary of Changes

This PR removes any space before or after the Users Name, Group name, User Note Subject.

Testing Instructions

In the back-end:

  • Users > Manage > edit a person and add spaces before the Name
  • Users > Groups > edit a group and add spaces before the Group Title
  • Users > User Notes > create a new note and add spaces before the Subject

Actual result BEFORE applying this Pull Request

Users > Manage > edit a person and add spaces before the Name
User-before

Users > Groups > edit a group and add spaces before the Group Title
Group-before

Users > User Notes > create a new note and add spaces before the Subject
user-notes

Expected result AFTER applying this Pull Request

Users > Manage > edit a person and add spaces before the Name
user-after

Users > Groups > edit a group and add spaces before the Group Title
group-after

Users > User Notes > create a new note and add spaces before the Subject
user-note-after

Link to documentations

Please select:

  • Documentation link for docs.joomla.org:

  • No documentation changes for docs.joomla.org needed

  • Pull Request link for manual.joomla.org:

  • No documentation changes for manual.joomla.org needed

avatar pe7er pe7er - open - 20 May 2025
avatar pe7er pe7er - change - 20 May 2025
Status New Pending
avatar joomla-cms-bot joomla-cms-bot - change - 20 May 2025
Category Administration com_users
avatar exlemor exlemor - test_item - 20 May 2025 - Tested successfully
avatar exlemor
exlemor - comment - 20 May 2025

I have tested this item ✅ successfully on b8d6413

I have successfully test this... Thanks pe7er!


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/45505.

avatar krishnaGandhi11 krishnaGandhi11 - test_item - 23 May 2025 - Tested successfully
avatar krishnaGandhi11
krishnaGandhi11 - comment - 23 May 2025

I have tested this item ✅ successfully on b8d6413

Tested successfully, works as expected!



As I tested all the PRs from 45502 to 45509 but no PR includes fix for

  1. Users>Fields(title)
  2. Users>Field Groups(title)
    I believe I did not miss it
    This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/45505.
avatar QuyTon QuyTon - change - 23 May 2025
Status Pending Ready to Commit
Labels Added: PR-5.3-dev
avatar QuyTon
QuyTon - comment - 23 May 2025

RTC


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/45505.

avatar Fedik Fedik - change - 25 May 2025
Status Ready to Commit Pending
avatar Fedik
Fedik - comment - 25 May 2025
avatar webmasterab webmasterab - test_item - 25 May 2025 - Tested successfully
avatar webmasterab
webmasterab - comment - 25 May 2025

I have tested this item ✅ successfully on b8d6413

Tested this and the titles are saved properly without the spaces before or after.

However, with the Notes you also have categories and if I create them with spaces, they remain.
But I see that this is also not included in this PR


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/45505.

avatar HLeithner HLeithner - change - 4 Jun 2025
Status Pending Closed
Closed_Date 0000-00-00 00:00:00 2025-06-04 18:21:13
Closed_By HLeithner
Labels Added: RMDQ
avatar HLeithner HLeithner - close - 4 Jun 2025
avatar HLeithner
HLeithner - comment - 4 Jun 2025

Hi @pe7er

thanks for the PR but we discussed this now several times in maintainers channel and come to the following conclusion:

  1. Fedir mentioned in comment that this would prevent our default filter
  2. We shouldn't touch user input if not really needed.

So I'm closing this PR.

Add a Comment

Login with GitHub to post a comment