User tests: Successful: Unsuccessful:
Pull Request for Issue # .
This pull request (PR) updates the lists of files and folders to be deleted on update in script.php to the latest changes in the 6.0-dev branch since the last PR of this kind for that branch, which was #45038 . In details these changes are:
In addition, it adds exceptions for the files and folders which belong to the Joomla 5 Backward Compatibility plugin to the deleted_file_check.php script so that these folders will not be deleted by the "deleteUnexistingFiles" method in script.php, as these folders will already be deleted by the "uninstallExtensions" method in script.php.
Finally, it adds exceptions for the "administrator/language/en-GB/guidedtours.joomla_whatsnew_5_4.ini" and "administrator/language/en-GB/guidedtours.joomla_whatsnew_5_4_steps.ini" files to the deleted_file_check.php script, as we do not want to deletedf these files on update, see also PR #45512 .
Code review, or if you want to do a real test:
Update a recent 5.4-dev nightly build to the latest 6.0-dev nightly build to get the actual result, and update a recent 5.4-dev nightly build to the patched package created by Drone for this PR to get the expected result.
After an update from a recent 5.4-dev nightly build to the latest 6.0-dev nightly build, the files and the folder added by this PR to the lists in script.php are still present.
After an update from a recent 5.4-dev nightly build to the patched package created by Drone for this PR, the files and the folder added by this PR to the lists in script.php have been deleted.
Please select:
Documentation link for docs.joomla.org:
No documentation changes for docs.joomla.org needed
Pull Request link for manual.joomla.org:
No documentation changes for manual.joomla.org needed
Status | New | ⇒ | Pending |
Category | ⇒ | Administration com_admin |
Labels |
Added:
PR-6.0-dev
|
Category | Administration com_admin | ⇒ | Administration com_admin Repository |
Status | Pending | ⇒ | Fixed in Code Base |
Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2025-05-26 10:25:58 |
Closed_By | ⇒ | softforge |
A big thankyou to @richard67 for the work in doing this and @Bodge-IT for testing at short notice on his holiday
I have tested this item ✅ successfully on 50ec078
Tested with latest nightly 5.4alpha1
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/45462.