PR-6.0-dev Pending

User tests: Successful: Unsuccessful:

avatar richard67
richard67
11 May 2025

Pull Request for Issue # .

Summary of Changes

This pull request (PR) updates the lists of files and folders to be deleted on update in script.php to the latest changes in the 6.0-dev branch since the last PR of this kind for that branch, which was #45038 . In details these changes are:

  • New 5.x update SQL scripts "5.4.0-2025-04-23.sql" and "5.4.0-2025-05-10.sql" for both kinds of databases, and "5.3.1-2025-04-27.sql" for PostgreSQL only.
  • Files "CaseFolding.php", "CaseFoldingData.php" and "CaseFoldingDataInterface.php" in folder "libraries/vendor/algo26-matthias/idna-convert/src/NamePrep" from PR #45140 , which was reverted later in the 5.3-dev branch but not in the 6.0-dev branch as we do that dependency update with 6.0.
  • Folder "libraries/vendor/typo3" and all subfolders and files in it from PR #45256 .
  • Folder "libraries/vendor/voku" and all subfolders and files in it from PR #44654 .
  • Folder "libraries/vendor/symfony/polyfill-iconv" and all subfolders and files in it from the same PR #44654 .
  • Files "administrator/language/en-GB/plg_behaviour_compat.ini" and "administrator/language/en-GB/plg_behaviour_compat.sys.ini" from PR #45480

In addition, it adds exceptions for the files and folders which belong to the Joomla 5 Backward Compatibility plugin to the deleted_file_check.php script so that these folders will not be deleted by the "deleteUnexistingFiles" method in script.php, as these folders will already be deleted by the "uninstallExtensions" method in script.php.

Finally, it adds exceptions for the "administrator/language/en-GB/guidedtours.joomla_whatsnew_5_4.ini" and "administrator/language/en-GB/guidedtours.joomla_whatsnew_5_4_steps.ini" files to the deleted_file_check.php script, as we do not want to deletedf these files on update, see also PR #45512 .

Testing Instructions

Code review, or if you want to do a real test:

Update a recent 5.4-dev nightly build to the latest 6.0-dev nightly build to get the actual result, and update a recent 5.4-dev nightly build to the patched package created by Drone for this PR to get the expected result.

Actual result BEFORE applying this Pull Request

After an update from a recent 5.4-dev nightly build to the latest 6.0-dev nightly build, the files and the folder added by this PR to the lists in script.php are still present.

Expected result AFTER applying this Pull Request

After an update from a recent 5.4-dev nightly build to the patched package created by Drone for this PR, the files and the folder added by this PR to the lists in script.php have been deleted.

Link to documentations

Please select:

  • Documentation link for docs.joomla.org:

  • No documentation changes for docs.joomla.org needed

  • Pull Request link for manual.joomla.org:

  • No documentation changes for manual.joomla.org needed

avatar richard67 richard67 - open - 11 May 2025
avatar richard67 richard67 - change - 11 May 2025
Status New Pending
avatar joomla-cms-bot joomla-cms-bot - change - 11 May 2025
Category Administration com_admin
avatar richard67 richard67 - change - 11 May 2025
The description was changed
avatar richard67 richard67 - edited - 11 May 2025
avatar richard67 richard67 - change - 11 May 2025
The description was changed
avatar richard67 richard67 - edited - 11 May 2025
avatar richard67 richard67 - change - 11 May 2025
The description was changed
avatar richard67 richard67 - edited - 11 May 2025
avatar richard67 richard67 - change - 11 May 2025
The description was changed
avatar richard67 richard67 - edited - 11 May 2025
avatar richard67 richard67 - change - 25 May 2025
Labels Added: PR-6.0-dev
avatar joomla-cms-bot joomla-cms-bot - change - 25 May 2025
Category Administration com_admin Administration com_admin Repository
avatar richard67 richard67 - change - 25 May 2025
The description was changed
avatar richard67 richard67 - edited - 25 May 2025
avatar richard67 richard67 - change - 26 May 2025
The description was changed
avatar richard67 richard67 - edited - 26 May 2025
avatar Bodge-IT Bodge-IT - test_item - 26 May 2025 - Tested successfully
avatar Bodge-IT
Bodge-IT - comment - 26 May 2025

I have tested this item ✅ successfully on 50ec078

Tested with latest nightly 5.4alpha1


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/45462.

avatar softforge softforge - change - 26 May 2025
Status Pending Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 2025-05-26 10:25:58
Closed_By softforge
avatar softforge softforge - close - 26 May 2025
avatar softforge softforge - merge - 26 May 2025
avatar softforge
softforge - comment - 26 May 2025

A big thankyou to @richard67 for the work in doing this and @Bodge-IT for testing at short notice on his holiday

avatar richard67
richard67 - comment - 26 May 2025

@Bodge-IT Thanks for testing. Much appreciated.

Add a Comment

Login with GitHub to post a comment