RTC bug PR-5.3-dev Pending

User tests: Successful: Unsuccessful:

avatar Hackwar
Hackwar
12 May 2025

Summary of Changes

Smart Search parses HTML content among other things by stripping the tags from it and then splitting it at the whitespace. Unfortunately if you have content which has no whitespace without the HTML tags, Smart Search will fail to index that content entirely. In my specific case, my articles contain tables of product numbers, which are generated by a plugin and thus don't contain any whitespace. This PR extends the list of elements to "space out" a bit before stripping the tags, so that Smart Search will be able to still index this.

Testing Instructions

  1. Switch to no editor in your site for this test. TinyMCE for example will automatically format the below code, thus inserting spaces.
  2. Create an article and paste the following as content: <table><tr><td>Test</td><td>String</td><td>String</td><td>String</td><td>String</td><td>String</td><td>String</td><td>String</td><td>String</td><td>String</td><td>String</td></table>
  3. Save the article
  4. Search for String in the frontend.
  5. Apply patch
  6. Clear index and start indexing again (The bug is during indexing, so you can't just apply the patch and search again directly.)

Actual result BEFORE applying this Pull Request

No search result.

Expected result AFTER applying this Pull Request

The above article shows up.

Link to documentations

Please select:

  • Documentation link for docs.joomla.org:

  • No documentation changes for docs.joomla.org needed

  • Pull Request link for manual.joomla.org:

  • No documentation changes for manual.joomla.org needed

avatar Hackwar Hackwar - open - 12 May 2025
avatar Hackwar Hackwar - change - 12 May 2025
Status New Pending
avatar joomla-cms-bot joomla-cms-bot - change - 12 May 2025
Category Administration com_finder
avatar chmst chmst - test_item - 12 May 2025 - Tested successfully
avatar chmst
chmst - comment - 12 May 2025

I have tested this item ✅ successfully on f364cf0

Following instructions with the prepard content table.


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/45464.

avatar brianteeman brianteeman - test_item - 12 May 2025 - Tested successfully
avatar brianteeman
brianteeman - comment - 12 May 2025

I have tested this item ✅ successfully on f364cf0

confirmed with two versions of the article - one created with no editor and one created with tinymce

before - only the tinymce version was found by com_finder
after - both versions were found


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/45464.

avatar exlemor
exlemor - comment - 12 May 2025

You guys @chmst and @brianteeman rock, and were so fast, I just saw the message asking for testing now and you had already tested... 👏🏻👏🏻

avatar Hackwar
Hackwar - comment - 12 May 2025

Thank you very much for testing!

avatar richard67 richard67 - change - 12 May 2025
Status Pending Ready to Commit
Labels Added: bug PR-5.3-dev
avatar richard67
richard67 - comment - 12 May 2025

RTC


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/45464.

avatar richard67 richard67 - change - 12 May 2025
Labels Added: RTC
avatar rdeutz rdeutz - change - 12 May 2025
Status Ready to Commit Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 2025-05-12 14:21:24
Closed_By rdeutz
avatar rdeutz rdeutz - close - 12 May 2025
avatar rdeutz rdeutz - merge - 12 May 2025

Add a Comment

Login with GitHub to post a comment