Failure

User tests: Successful: 0 Unsuccessful: 0

avatar 3idey
3idey
19 Mar 2025

Summary

This PR improves error handling in renameItem() in the Joomla Media Manager. It replaces raw error throws with Joomla notifications, ensuring better user feedback and using Joomla's Notification System Instead of Throwing Errors

Changes Made

  • Updated renameItem() to use notifications.error() instead of throw new Error(error);
  • Ensured that errors are properly logged in Joomla’s notification system.
  • Improve File Exists Handling (Duplicate Files).

Testing Instructions

  • Open Joomla Media Manager.
  • Try renaming a file to an invalid name (e.g., same name as an existing file).
  • You should see an error notification instead of the app crashing.

Checklist

  • Code follows Joomla's coding standards.
  • Fix does not introduce new bugs.
  • Properly tested within Joomla.
avatar 3idey 3idey - open - 19 Mar 2025
avatar 3idey 3idey - change - 19 Mar 2025
Status New Pending
avatar joomla-cms-bot joomla-cms-bot - change - 19 Mar 2025
Category JavaScript Administration com_media NPM Change
avatar 3idey 3idey - change - 19 Mar 2025
The description was changed
avatar 3idey 3idey - edited - 19 Mar 2025
avatar 3idey 3idey - change - 19 Mar 2025
The description was changed
avatar 3idey 3idey - edited - 19 Mar 2025
avatar 3idey 3idey - change - 19 Mar 2025
The description was changed
avatar 3idey 3idey - edited - 19 Mar 2025
avatar 3idey
3idey - comment - 19 Mar 2025

@richard67 @laoneo can you tell me is there anything that needs to be fixed.

avatar 3idey 3idey - change - 20 Mar 2025
The description was changed
avatar 3idey 3idey - edited - 20 Mar 2025

Add a Comment

Login with GitHub to post a comment