[#45164] - [5.3] Fix error handling rename item
- Closed
- 9 May 2025
- Medium
- Build: 5.2-dev
- # 45164
- Diff
- 3idey:fix-error-handling-renameItem
- Failure continuous-integration/appveyor/pr AppVeyor build failed Details
- Success Download Prebuilt packages are available for download. Details
- Success continuous-integration/drone/pr Build is passing Details
User tests: Successful: Unsuccessful:
Summary
This PR improves error handling in renameItem() in the Joomla Media Manager. It replaces raw error throws with Joomla notifications, ensuring better user feedback and using Joomla's Notification System Instead of Throwing Errors
Changes Made
- Updated renameItem() to use notifications.error() instead of throw new Error(error);
- Ensured that errors are properly logged in Joomla’s notification system.
- Improve File Exists Handling (Duplicate Files).
Testing Instructions
- Open Joomla Media Manager.
- Try renaming a file to an invalid name (e.g., same name as an existing file).
- You should see an error notification instead of the app crashing.
Checklist
- Code follows Joomla's coding standards.
- Fix does not introduce new bugs.
- Properly tested within Joomla.
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | JavaScript Administration com_media NPM Change |
This pull request has been automatically rebased to 5.3-dev.
| Title |
|
||||||
Will it be merged soon @HLeithner
@3idey thanks for the PR, please revert the package-lock.json which seems to be unrelated.
@Fedik @joomdonation can you have a look?
Looks good.
| Labels |
Added:
NPM Resource Changed
bug
PR-5.2-dev
PR-5.3-dev
|
||
Done. @HLeithner
Done. @HLeithner
@3idey Not right. Check the changed files of your PR on GitHub: https://github.com/joomla/joomla-cms/pull/45164/files
Now you PR deletes the package-lock-json file.
You should have reverted the changes in that file, not delete that file.
@HLeithner @richard67 what about now ? I revert the version to "5.2.1"
@HLeithner @richard67 what about now ? I revert the version to "5.2.1"
@3idey Yes, but at the wrong place. Again: Check the changed files of your PR on GitHub here: https://github.com/joomla/joomla-cms/pull/45164/files . Then you will see that.
@richard67 I'm so sorry for the confusion that I made. now it should be good
@richard67 I'm so sorry for the confusion that I made. now it should be good
@3idey Yes, now it looks alright. I've allowed myself to update the branch to the base (5.3-dev), so now the PR shows only 2 changed files and no obviously unrelated changes. Please check again on https://github.com/joomla/joomla-cms/pull/45164/files if something is missing or if it looks complete to you. Thanks in advance.
@richard67 Everything looks great. Thanks
@HLeithner Done.
I tried to rename an existing image to the same name as another existing image
Before This PR
With this PR
| Status | Pending | ⇒ | Closed |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2025-05-09 12:02:47 |
| Closed_By | ⇒ | 3idey | |
| Labels |
Removed:
PR-5.2-dev
|
||
@richard67 @laoneo can you tell me is there anything that needs to be fixed.