Feeling Lucky
Unit/System Tests
NPM Resource Changed
PR-5.2-dev
[#45163] - fix error handling and improve file exists handling
- Closed
- 19 Mar 2025
- Medium
- Build: 5.2-dev
- # 45163
- Diff
- 3idey:fix-error-handling-renameItem
User tests: Successful: 0 Unsuccessful: 0
Summary
This PR improves error handling in renameItem() in the Joomla Media Manager. It replaces raw error throws with Joomla notifications, ensuring better user feedback and using Joomla's Notification System Instead of Throwing Errors
Note
My changes only affect JavaScript files (Notifications.es6.js & actions.es6.js). The PHPStan errors are unrelated.
AppVeyor is failing, but my PR only changes JavaScript files. The failure seems unrelated (if there is any issue that i can't see, please tell me what to do ).
Changes Made
- Updated
renameItem()to usenotifications.error()instead ofthrow new Error(error); - Ensured that errors are properly logged in Joomla’s notification system.
- Improve File Exists Handling (Duplicate Files).
Testing Instructions
- Open Joomla Media Manager.
- Try renaming a file to an invalid name (e.g., same name as an existing file).
- You should see an error notification instead of the app crashing.
Checklist
- Code follows Joomla's coding standards.
- Fix does not introduce new bugs.
- Properly tested within Joomla.
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | JavaScript Administration com_media NPM Change |
| Labels |
Added:
NPM Resource Changed
PR-5.2-dev
|
||
The description was changed
The description was changed
The description was changed
The description was changed
The description was changed
The description was changed
The description was changed
| Category | JavaScript Administration com_media NPM Change | ⇒ | Unit Tests JavaScript Administration com_media NPM Change |
| Labels |
Added:
Unit/System Tests
|
||
| Status | Pending | ⇒ | Closed |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2025-03-19 17:52:16 |
| Closed_By | ⇒ | 3idey |
The description was changed