The styling on this is off, there is a size issue with white space at the bottom AND there is now the word Select at the top

before

after

This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/4513.

Before:

Now it should act exactly as the old modal + now it is responsive

Why have you added the title Select or upload an image?
On 11 Oct 2014 15:12, "Dimitri Grammatiko" notifications@github.com wrote:

Now it should act exactly as the old modal + now it is responsive
[image: screenshot 2014-10-11 17 11 05]
https://cloud.githubusercontent.com/assets/3889375/4602869/a1404768-5150-11e4-9e47-55d0a39c4523.png

—
Reply to this email directly or view it on GitHub
#4513 (comment).

Bootstrap modal needs a title: http://getbootstrap.com/2.3.2/javascript.html#modals
If we leave it blank the layout gets ugly, I guess that’s the drawback here, we add another string

@infograf thought s on adding another string etc
On 11 Oct 2014 16:52, "Dimitri Grammatiko" notifications@github.com wrote:

Bootstrap modal needs a title:
http://getbootstrap.com/2.3.2/javascript.html#modals
If we leave it blank the layout gets ugly, I guess that’s the drawback
here, we add another string

—
Reply to this email directly or view it on GitHub
#4513 (comment).

@brianteeman
No problem adding new strings in 3.4.0

@brianteeman Can you provide some appropriate titles for the modals, so I don’t make a bunch of commits?
The PR are #4514 #4561 #4562 #4563 #4575

@Bakual how can I solve this:

This pull request contains merge conflicts that must be resolved.
?

That's very likely due to our friends from the codestyle sprint

What you need to do is update your branch https://github.com/dgt41/joomla-cms/tree/media_field_bs_modal to current staging and resolve any conflicts that may have occured.

There are two possible ways of getting the branch updated:

• Easy: Just merge staging (from the joomla/joomla-cms repo) into your branch. This will create a "merge-commit".
• Nice: Rebase your branch with staging. This way, git will kind of rewind your changes, apply all commits from staging and then reapply your commits again. If done properly your PR will still look exactly the same as now, with only your commits.

@test, it works fine.

This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/4513.

Moving to RTC as issue patch more than 2 successfull tests

@Bakual and the rest of the PLT:

The PRs regarding Media Field, User Field and Content History are also used in the front end. That might break the rendered design IF THE TEMPLATE is not BOOTSTRAP compatible. (the old modal uses it’s own css file). I wrote it!

For B/C I reverted the option to use the mootools modal in front end. Lets NOT break every site out there.
Please test again

The PRs regarding Media Field, User Field and Content History are also used in the front end. That might break the rendered design IF THE TEMPLATE is not BOOTSTRAP compatible. (the old modal uses it’s own css file). I wrote it!

I'm sorry to say, but if it's going to break templates that worked fine before, then this will obviously not pass. We will need a different approach then.

I closed all 4 requests that infect also the front end. I will do them again as soon as #3231 is committed! Better safe than sorry…