[#4514] - Move user field to bs modal
- Closed
- 19 Oct 2014
- Medium
- Build: staging
- # 4514
- Diff
- dgt41:user_field_bs_modal
- Success The Travis CI build passed Details
User tests: Successful: Unsuccessful:
Same as #4513 but for User
User select field (field type user) is using mootools modal.
Without affecting in anyway the logic of the field we can use jQuery and bootstrap.
B/C
Should be 100% compatible
Test:
Apply the patch
Go to administrator -> Banners -> create a new banner
and check the functionality of created by in publishing tab
Everything should be ok
jissues-bot
- | Labels |
Added:
?
|
||
Also this PR changes the styling of the button
##before
#after
This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/4514.
@brianteeman I corrected the button appearance, but for the group list I need some more time
Edit: was a sizing thing
Before:
After:
Why have you added the title Select User?
On 11 Oct 2014 15:15, "Dimitri Grammatiko" notifications@github.com wrote:
Before:
[image: screenshot 2014-10-11 17 14 03]
https://cloud.githubusercontent.com/assets/3889375/4602877/06e1d1c2-5151-11e4-9d60-3cf838c4f432.pngAfter:
[image: screenshot 2014-10-11 17 14 42]
https://cloud.githubusercontent.com/assets/3889375/4602879/0c145566-5151-11e4-85ed-c7ab1a21e232.png—
Reply to this email directly or view it on GitHub
#4514 (comment).
nicksavov
- | Labels |
Added:
?
|
||
@test It work for me
This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/4514.
@test
This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/4514.
Multiple good tests - setting to RTC
This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/4514.
| Status | Pending | ⇒ | Ready to Commit |
micker
-
@brianteeman and the rest of the PLT:
The PRs regarding Media Field, User Field and Content History are also used in the front end. That might break the rendered design IF THE TEMPLATE is not BOOTSTRAP compatible. (the old modal uses it’s own css file). I wrote it!
| Status | Ready to Commit | ⇒ | Needs Review |
For B/C I reverted the option to use the bootstrap modal in front end. Lets NOT break every site out there.
Please test again
@wilsonge @phproberto Can we move this user field (as well as the media and contenthistory) to layout? It will be a lot easier and cleaner to do an override...
Of course we can! The plan is to do it for all form fields as soon as possible.
Get the JLayouts looking in a similar way to the code here #3231 - me and @phproberto are still finalising the layout the renderer itself because we want to have a shared renderer between new MVC and these form fields. But just moving it into a Layout will get us 99% of the way there
| Status | Needs Review | ⇒ | Closed |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2014-10-19 16:05:58 |
As far as I can see this doesnt work correctly as I dont get the User Group filter
## before
## after
This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/4514.