[#45057] - [5.3] use DatabaseFactory in DatabaseServiceProvider
- Pending
- Medium
- Build: 5.3-dev
- # 45057
- Diff
- heelc29:5.3/database/provider
User tests: Successful: Unsuccessful:
Summary of Changes
DatabaseDriver::getInstance is deprecated and should be replaced with DatabaseFactory->getDriver()
https://github.com/joomla-framework/database/blob/d13a7504471b4730a8107e3566c6fe6d476706fc/src/DatabaseDriver.php#L269-L288
Testing Instructions
install Joomla and visit frontend/backend and see if you can do anything (connection to database is preset)
Actual result BEFORE applying this Pull Request
Warning in deprecated log: DatabaseDriver::getInstance is deprecated and will be removed in 3.0, use DatabaseFactory::getDriver() instead.
------ --------------------------------------------------
Line libraries/src/Service/Provider/Database.php
------ --------------------------------------------------
123 Call to deprecated method getInstance() of class
Joomla\Database\DatabaseDriver:
3.0 Use DatabaseFactory::getDriver() instead
🪪 staticMethod.deprecated
------ --------------------------------------------------
Expected result AFTER applying this Pull Request
Warning gone
Link to documentations
Please select:
- No documentation changes for docs.joomla.org needed
- No documentation changes for manual.joomla.org needed
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | Libraries |
| Labels |
Added:
PR-5.3-dev
|
||
Hi @heelc29, I might be doing something incorrectly or the testing instructions are incomplete or I couldn't replicate the BEFORE condition as I could not find in the Deprecated.php log any mention of Call to deprecated method getInstance() of class
Joomla\Database\DatabaseDriver:
3.0 Use DatabaseFactory::getDriver() instead
🪪 staticMethod.deprecated
You night want to update your Testing Instructions to advise the turn: Log Deprecated API in Global Configuration if that is where a tester is supposed to find this information...
Hi @heelc29, I might be doing something incorrectly or the testing instructions are incomplete or I couldn't replicate the BEFORE condition as I could not find in the Deprecated.php log any mention of Call to deprecated method getInstance() of class Joomla\Database\DatabaseDriver: 3.0 Use DatabaseFactory::getDriver() instead 🪪 staticMethod.deprecated
Hi @exlemor sorry that I was a bit unclear in the description ... this message comes from phpstan in drone ci, I saw it also with XDebug.
You night want to update your Testing Instructions to advise the turn: Log Deprecated API in Global Configuration if that is where a tester is supposed to find this information...
Strangely, it is not logged here - probably because it is in the service provider?
| Category | Libraries | ⇒ | Administration com_config Installation Libraries JavaScript Unit Tests |
Update more DatabaseDriver::getInstance
Also add system test for config cli command
| Labels |
Added:
Unit/System Tests
|
||
Failing CI related to #45059