[#45056] - [6.0][joomla/database] use createQuery
- Pending
- Medium
- Build: 5.3-dev
- # 45056
- Diff
- heelc29:5.3/dababase/createquery
User tests: Successful: Unsuccessful:
Redo of Pull Request #42344.
DRAFT: due temporary update of joomla-framework/database#325
Summary of Changes
Replaced all fuction calls getQuery(true) with createQuery() but only in database related context.
Note: There is also a getQuery(true) functionality in Joomla\CMS\Uri\Uri that must remain untouched.
Testing Instructions
code review or check logs
Actual result BEFORE applying this Pull Request
Since joomla/database 2.2.0: The parameter $new is deprecated and will be removed in 4.0, use Joomla\Database\DatabaseDriver::createQuery() instead.
Expected result AFTER applying this Pull Request
No warnings for getQuery(true) from core files (still some in session framework)
Link to documentations
Please select:
- No documentation changes for docs.joomla.org needed
- No documentation changes for manual.joomla.org needed
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | Administration com_admin com_associations com_banners com_categories com_checkin com_config |
| Labels |
Added:
PR-5.3-dev
|
||
The problem is that getDatabase() returns a DatabaseInterface which doesn't have that function as it is only part of the DatabaseDriver class. So this pr would bind us to the concrete implementation.
@heelc29 Sadly, I see hundreds of use Joomla\Database\DatabaseDriver::createQuery() instead. - [ROOT]/libraries/vendor/symfony/deprecation-contracts/function.php - Line 25 BEFORE or AFTER the Patch...
I did many different things in the backend such as copy an article, upload an extension, etc etc WITH and WITHOUT the Patch applied and I sifted through ~8mg of deprecated.php log with no foreseeable difference...
What am I doing wrong?
It is also used for example in joomla framework session so this tries to replace that one caused directly from the cms
Yes the deprecated.php log grows quickly
| Title |
|
||||||
| Category | Administration com_admin com_associations com_banners com_categories com_checkin com_config | ⇒ | Unit Tests Administration com_admin SQL Postgresql com_associations com_banners com_categories |
| Labels |
Added:
Unit/System Tests
PR-6.0-dev
|
||
| Category | Administration com_admin com_associations com_banners com_categories Unit Tests SQL Postgresql | ⇒ | Administration com_admin com_associations com_banners com_categories com_checkin com_config |
| Labels |
Removed:
Unit/System Tests
|
||
| Labels |
Removed:
PR-5.3-dev
|
||
@heelc29 Sadly, I see hundreds of use Joomla\Database\DatabaseDriver::createQuery() instead. - [ROOT]/libraries/vendor/symfony/deprecation-contracts/function.php - Line 25 BEFORE or AFTER the Patch...
I did many different things in the backend such as copy an article, upload an extension, etc etc WITH and WITHOUT the Patch applied and I sifted through ~8mg of deprecated.php log with no foreseeable difference...
What am I doing wrong?
PHP 8.3.19, MariaDB 10.6.15, Joomla 5.3 ßeta 2