Feeling Lucky
RTC
bug
PR-5.3-dev
[#45027] - [5.3] Remove redundant entry in the npm tools
- Fixed in Code Base
- 9 Mar 2025
- Medium
- Build: 5.2-dev
- # 45027
- Diff
- dgrammatiko:patch-1
User tests: Successful: Unsuccessful:
Pull Request for Issue # .
Summary of Changes
- In J5 codemirror was upgraded to v6 with it's own build script but there's an entry in the minification of the vendors pointing to the vendor/codemirror folder. This is redundant
Testing Instructions
- Code review, the build, minification of any codemirror asset is happening on it's own script: https://github.com/joomla/joomla-cms/blob/5.2-dev/build/build-modules-js/javascript/build-codemirror.es6.js
Actual result BEFORE applying this Pull Request
Expected result AFTER applying this Pull Request
Link to documentations
Please select:
-
Documentation link for docs.joomla.org:
-
No documentation changes for docs.joomla.org needed
-
Pull Request link for manual.joomla.org:
-
No documentation changes for manual.joomla.org needed
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | JavaScript Repository |
brianteeman
- comment
- 27 Feb 2025
I have tested this item ✅ successfully on f0d9bba
verified that it does nothing
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/45027.
| Status | Pending | ⇒ | Ready to Commit |
| Labels |
Added:
PR-5.2-dev
|
||
QuyTon
- comment
- 27 Feb 2025
RTC
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/45027.
| Labels |
Added:
RTC
bug
|
||
laoneo
- comment
- 9 Mar 2025
I'v rebased it to 5.3. Can you fix the conflict please?
| Title |
|
||||||
| Labels |
Added:
PR-5.3-dev
Removed: PR-5.2-dev |
||
| Status | Ready to Commit | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2025-03-09 13:14:54 |
| Closed_By | ⇒ | rdeutz |
rdeutz
- comment
- 9 Mar 2025
Thanks
I have tested this item ✅ successfully on f0d9bba
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/45027.