User tests: Successful: Unsuccessful:
The file libraries/src/Component/Router/RouterView.php did not have Text::_() to translate the language string JLIB_APPLICATION_ERROR_ROUTER_GET_NAME. Furthermore this language string was not inside the language files.
I've replaced the error with the more generic error JLIB_APPLICATION_ERROR_GET_NAME like in libraries/src/MVC/View/AbstractView.php (Thanks @Hackwar for this suggestion!)
Code review
Please select:
Documentation link for docs.joomla.org:
No documentation changes for docs.joomla.org needed
Pull Request link for manual.joomla.org:
No documentation changes for manual.joomla.org needed
| Status | New | ⇒ | Pending |
| Category | ⇒ | Libraries |
This pull request has been automatically rebased to 5.3-dev.
| Title |
|
||||||
wow that string has never been present in the 10 years since the code was added
I have tested this item ✅ successfully on 0f25307
Actually, my test was incomplete - it can't be taken into account
| Status | Pending | ⇒ | Ready to Commit |
RTC
| Labels |
Added:
RTC
PBF
bug
PR-5.3-dev
|
||
| Status | Ready to Commit | ⇒ | Pending |
Back to pending. It cannot be merged with phpstan errors.
| Labels |
Added:
Updates Requested
Removed: RTC |
||
Please test again and watch your PHP error log while testing, with error reporting set to maximum. Thanks in advance.
This pull request has been automatically rebased to 5.4-dev.
| Title |
|
||||||
| Labels |
Added:
PR-5.4-dev
Removed: Updates Requested |
||
I have tested this item ✅ successfully on a953f42
| Labels |
Removed:
PBF
PR-5.3-dev
|
||
I have tested this item ✅ successfully on 8645e03
Tested with JBT, before the PR
!preg_match with true, called frontend an seen JLIB_APPLICATION_ERROR_ROUTER_GET_NAME exceptionJoomla\CMS\Component\Router\RouterView::getName: Can't get or parse class name.JLIB_APPLICATION_ERROR_ROUTER_GET_NAME anymore in source code| Status | Pending | ⇒ | Ready to Commit |
RTC
| Labels |
Added:
RTC
|
||
| Status | Ready to Commit | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2025-11-08 11:01:37 |
| Closed_By | ⇒ | richard67 |
I have tested this item ✅ successfully on 0f25307
I have tested this successfully. (Simple enough even for me)
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/45028.