User tests: Successful: Unsuccessful:
The file libraries/src/Component/Router/RouterView.php
did not have Text::_()
to translate the language string JLIB_APPLICATION_ERROR_ROUTER_GET_NAME
. Furthermore this language string was not inside the language files.
I've replaced the error with the more generic error JLIB_APPLICATION_ERROR_GET_NAME
like in libraries/src/MVC/View/AbstractView.php
(Thanks @Hackwar for this suggestion!)
Code review
Please select:
Documentation link for docs.joomla.org:
No documentation changes for docs.joomla.org needed
Pull Request link for manual.joomla.org:
No documentation changes for manual.joomla.org needed
Status | New | ⇒ | Pending |
Category | ⇒ | Libraries |
This pull request has been automatically rebased to 5.3-dev.
Title |
|
I have tested this item ✅ successfully on 0f25307
I have tested this successfully. (Simple enough even for me)
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/45028.