Pending

User tests: Successful: Unsuccessful:

avatar pe7er
pe7er
27 Feb 2025

The file libraries/src/Component/Router/RouterView.php did not have Text::_() to translate the language string JLIB_APPLICATION_ERROR_ROUTER_GET_NAME. Furthermore this language string was not inside the language files.

Summary of Changes

I've replaced the error with the more generic error JLIB_APPLICATION_ERROR_GET_NAME like in libraries/src/MVC/View/AbstractView.php (Thanks @Hackwar for this suggestion!)

Testing Instructions

Code review

Link to documentations

Please select:

  • Documentation link for docs.joomla.org:

  • No documentation changes for docs.joomla.org needed

  • Pull Request link for manual.joomla.org:

  • No documentation changes for manual.joomla.org needed

avatar pe7er pe7er - open - 27 Feb 2025
avatar pe7er pe7er - change - 27 Feb 2025
Status New Pending
avatar joomla-cms-bot joomla-cms-bot - change - 27 Feb 2025
Category Libraries
avatar exlemor exlemor - test_item - 16 Mar 2025 - Tested successfully
avatar exlemor
exlemor - comment - 16 Mar 2025

I have tested this item ✅ successfully on 0f25307

I have tested this successfully. (Simple enough even for me)


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/45028.

avatar HLeithner
HLeithner - comment - 15 Apr 2025

This pull request has been automatically rebased to 5.3-dev.

avatar HLeithner HLeithner - change - 15 Apr 2025
Title
[5.2] Fix for untranslated JLIB_APPLICATION_ERROR string
[5.3] Fix for untranslated JLIB_APPLICATION_ERROR string
avatar HLeithner HLeithner - edited - 15 Apr 2025

Add a Comment

Login with GitHub to post a comment