NPM Resource Changed b/c break PR-6.0-dev Pending

User tests: Successful: Unsuccessful:

avatar dgrammatiko
dgrammatiko
26 Feb 2025

Pull Request for Issue # .

Summary of Changes

  • Remove the tab state script (not in use since 4.0)

Testing Instructions

Actual result BEFORE applying this Pull Request

Expected result AFTER applying this Pull Request

Link to documentations

Please select:

  • Documentation link for docs.joomla.org:

  • No documentation changes for docs.joomla.org needed

  • Pull Request link for manual.joomla.org:

  • No documentation changes for manual.joomla.org needed

avatar dgrammatiko dgrammatiko - open - 26 Feb 2025
avatar dgrammatiko dgrammatiko - change - 26 Feb 2025
Status New Pending
avatar joomla-cms-bot joomla-cms-bot - change - 26 Feb 2025
Category JavaScript Repository NPM Change
avatar brianteeman
brianteeman - comment - 26 Feb 2025

why?

avatar dgrammatiko
dgrammatiko - comment - 26 Feb 2025

It’s not used anywhere since 4.0

avatar brianteeman
brianteeman - comment - 26 Feb 2025

then it should be deprecated ie advance notice given that it will be removed

avatar dgrammatiko
dgrammatiko - comment - 26 Feb 2025

It's already in the LEGACY folder, so by definition WAS deprecated

avatar brianteeman
brianteeman - comment - 26 Feb 2025

we will have to agree to disagree then on that

avatar dgrammatiko
dgrammatiko - comment - 26 Feb 2025

It's not the first time

avatar dgrammatiko
dgrammatiko - comment - 26 Feb 2025

I mean we had this conversation 6 years ago: #26838

avatar Fedik Fedik - test_item - 27 Feb 2025 - Tested successfully
avatar Fedik
Fedik - comment - 27 Feb 2025

I have tested this item ✅ successfully on 2bb62a6


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/45021.

avatar exlemor exlemor - test_item - 28 Feb 2025 - Tested successfully
avatar exlemor
exlemor - comment - 28 Feb 2025

I have tested this item ✅ successfully on 2bb62a6

I have tested this successfully.


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/45021.

avatar softforge softforge - change - 28 Feb 2025
Status Pending Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 2025-02-28 16:06:58
Closed_By softforge
Labels Added: NPM Resource Changed b/c break PR-6.0-dev
avatar softforge softforge - close - 28 Feb 2025
avatar softforge softforge - merge - 28 Feb 2025
avatar dgrammatiko
dgrammatiko - comment - 28 Feb 2025

@softforge please also merge joomla/Manual#414

Add a Comment

Login with GitHub to post a comment