[#45020] - [6.0] Move jquery-noconflict script
- Fixed in Code Base
- 4 Mar 2025
- Medium
- Build: 6.0-dev
- # 45020
- Diff
- dgrammatiko:6.0-dev/jquery-noconflict
User tests: Successful: Unsuccessful:
Pull Request for Issue # .
Summary of Changes
- Move jquery-noconflict script to the appropriate folder
media/vendor/jquery/js
Testing Instructions
Actual result BEFORE applying this Pull Request
Expected result AFTER applying this Pull Request
Link to documentations
Please select:
-
Documentation link for docs.joomla.org:
-
No documentation changes for docs.joomla.org needed
-
Pull Request link for manual.joomla.org:
-
No documentation changes for manual.joomla.org needed
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | Repository NPM Change JavaScript |
I have tested this item 🔴 unsuccessfully on ac225bb
after applying the pr and then npm i I expected to find the jquery-noconflict.js in the media/vendor/jquery folder but it was not there even though thats where media\vendor\joomla.asset.json says it should be
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/45020.
| Labels |
Added:
NPM Resource Changed
PR-6.0-dev
Enhancement
|
||
@brianteeman thanks, somehow I used .esm.js instead of .es6.js
I have tested this item ✅ successfully on ac225bb
real tests produce real results
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/45020.
@dgrammatiko Could you fix the linter error reported here? https://ci.joomla.org/joomla/joomla-cms/82752/1/20 Thanks in advance.
Restoring @brianteeman 's test result in the issue tracker as the commit which has invalidated the test count was just a linter hint.
@Fedik Could you test again? After your test a relevant change had been made: 64307f0
I have tested this item ✅ successfully on f368dfa
Still looks good to me :)
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/45020.
| Status | Pending | ⇒ | Ready to Commit |
RTC
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/45020.
| Labels |
Added:
RTC
|
||
softforge
- | Status | Ready to Commit | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2025-03-04 09:07:20 |
| Closed_By | ⇒ | softforge |
I will, although the entry is used in the joomla.assets.json, it shouldn't be used directly
I have tested this item ✅ successfully on ac225bb
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/45020.