RTC NPM Resource Changed b/c break PR-6.0-dev Pending

User tests: Successful: Unsuccessful:

avatar dgrammatiko
dgrammatiko
26 Feb 2025

Pull Request for Issue # .

Summary of Changes

  • Remove the really outdated (and not used since 4.0) chosen.js
  • Remove the old Tags scripts that used it
  • cleanup the build tools
  • Cleanup serachtools and the cassiopeia references to chosen js and css

Testing Instructions

Chosen is not used anywhere in the J4/5 so just checking that the filters in the list view of articles still works is a successful test (the filters had some code removed)

Actual result BEFORE applying this Pull Request

Expected result AFTER applying this Pull Request

Link to documentations

Please select:

  • Documentation link for docs.joomla.org:

  • No documentation changes for docs.joomla.org needed

  • Pull Request link for manual.joomla.org:

  • No documentation changes for manual.joomla.org needed

avatar dgrammatiko dgrammatiko - open - 26 Feb 2025
avatar dgrammatiko dgrammatiko - change - 26 Feb 2025
Status New Pending
avatar joomla-cms-bot joomla-cms-bot - change - 26 Feb 2025
Category JavaScript Repository NPM Change
avatar dgrammatiko dgrammatiko - change - 26 Feb 2025
The description was changed
avatar dgrammatiko dgrammatiko - edited - 26 Feb 2025
avatar Fedik Fedik - test_item - 27 Feb 2025 - Tested successfully
avatar Fedik
Fedik - comment - 27 Feb 2025

I have tested this item ✅ successfully on 77d8b3e


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/45018.

avatar brianteeman
brianteeman - comment - 27 Feb 2025

Remove the old Tags scripts that used it

where

avatar dgrammatiko
dgrammatiko - comment - 27 Feb 2025

@brianteeman I guess my comment is confusing, I mean there are 2 files (build/media_source/legacy/js/ajax-chosen.es5.js, build/media_source/legacy/js/joomla-chosen.es5.js) that depend on chosen and these are removed. Joomla 4+ doesn't use anywhere chosen thus chosen and the 2 files are removed. Also cleaned up any scripts that had chosen references

avatar brianteeman
brianteeman - comment - 27 Feb 2025

I assumed you referred to \build\media_source\system\js\fields\tag.es5.js which appears to use chosen and is not touched by this PR

avatar dgrammatiko dgrammatiko - change - 27 Feb 2025
Labels Added: NPM Resource Changed Removal PR-6.0-dev
avatar dgrammatiko
dgrammatiko - comment - 27 Feb 2025

I assumed you referred to \build\media_source\system\js\fields\tag.es5.js

That's the other part of the J3 tags that obviously I missed! Thanks

avatar brianteeman brianteeman - test_item - 27 Feb 2025 - Tested successfully
avatar brianteeman
brianteeman - comment - 27 Feb 2025

I have tested this item ✅ successfully on 7b801be

real tests produce real results


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/45018.

avatar dgrammatiko dgrammatiko - change - 30 Mar 2025
Labels Added: b/c break
Removed: Removal
avatar dgrammatiko
dgrammatiko - comment - 17 Jul 2025

@softforge any interest here?

avatar dgrammatiko dgrammatiko - change - 26 Jul 2025
The description was changed
avatar dgrammatiko dgrammatiko - edited - 26 Jul 2025
avatar brianteeman
brianteeman - comment - 15 Aug 2025

would be good to get this merged

avatar Fedik Fedik - test_item - 15 Aug 2025 - Tested successfully
avatar Fedik
Fedik - comment - 15 Aug 2025

I have tested this item ✅ successfully on 42f6b65


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/45018.

avatar Fedik Fedik - change - 15 Aug 2025
Status Pending Ready to Commit
avatar Fedik
Fedik - comment - 15 Aug 2025

r2c


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/45018.

avatar richard67 richard67 - change - 16 Aug 2025
Labels Added: RTC
avatar softforge softforge - change - 16 Aug 2025
Status Ready to Commit Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 2025-08-16 12:18:06
Closed_By softforge
avatar softforge softforge - close - 16 Aug 2025
avatar softforge softforge - merge - 16 Aug 2025
avatar softforge
softforge - comment - 16 Aug 2025

Thank you to all involved, good job

avatar richard67
richard67 - comment - 16 Aug 2025

@dgrammatiko @Fedik Can the media/vendor/chosen folder be removed on update? Or do we have to keep it? Am asking because working on the deleted files and folders lists in script.php.

avatar brianteeman
brianteeman - comment - 16 Aug 2025

@richard67 not only "can it" but "it must be removed" otherwise we are leaving files behind that might be exposed as being vulnerable in the future and we wouldnt do anything about it because we wouldnt know

avatar dgrammatiko
dgrammatiko - comment - 16 Aug 2025

We should delete it

avatar richard67
richard67 - comment - 16 Aug 2025

For deleting obsolete files and folders on update see #45928 .

Add a Comment

Login with GitHub to post a comment