User tests: Successful: Unsuccessful:
Pull Request for Issue # .
Chosen is not used anywhere in the J4/5 so just checking that the filters in the list view of articles still works is a successful test (the filters had some code removed)
Please select:
Documentation link for docs.joomla.org:
No documentation changes for docs.joomla.org needed
Pull Request link for manual.joomla.org:
No documentation changes for manual.joomla.org needed
Status | New | ⇒ | Pending |
Category | ⇒ | JavaScript Repository NPM Change |
Remove the old Tags scripts that used it
where
@brianteeman I guess my comment is confusing, I mean there are 2 files (build/media_source/legacy/js/ajax-chosen.es5.js, build/media_source/legacy/js/joomla-chosen.es5.js) that depend on chosen and these are removed. Joomla 4+ doesn't use anywhere chosen thus chosen and the 2 files are removed. Also cleaned up any scripts that had chosen references
I assumed you referred to \build\media_source\system\js\fields\tag.es5.js
which appears to use chosen and is not touched by this PR
Labels |
Added:
NPM Resource Changed
Removal
PR-6.0-dev
|
I assumed you referred to \build\media_source\system\js\fields\tag.es5.js
That's the other part of the J3 tags that obviously I missed! Thanks
I have tested this item ✅ successfully on 7b801be
real tests produce real results
Labels |
Added:
b/c break
Removed: Removal |
@softforge any interest here?
would be good to get this merged
I have tested this item ✅ successfully on 42f6b65
Status | Pending | ⇒ | Ready to Commit |
r2c
Labels |
Added:
RTC
|
Status | Ready to Commit | ⇒ | Fixed in Code Base |
Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2025-08-16 12:18:06 |
Closed_By | ⇒ | softforge |
Thank you to all involved, good job
@dgrammatiko @Fedik Can the media/vendor/chosen
folder be removed on update? Or do we have to keep it? Am asking because working on the deleted files and folders lists in script.php.
@richard67 not only "can it" but "it must be removed" otherwise we are leaving files behind that might be exposed as being vulnerable in the future and we wouldnt do anything about it because we wouldnt know
We should delete it
I have tested this item ✅ successfully on 77d8b3e
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/45018.