[#45018] - [6.0] Remove chosen
- Pending
- Medium
- Build: 6.0-dev
- # 45018
- Diff
- dgrammatiko:6.0-dev/remove-chosen
User tests: Successful: Unsuccessful:
Pull Request for Issue # .
Summary of Changes
- Remove the really outdated (and not used since 4.0) chosen.js
- Remove the old Tags scripts that used it
- cleanup the build tools
- Cleanup serachtools and the cassiopeia references to chosen js and css
Testing Instructions
Actual result BEFORE applying this Pull Request
Expected result AFTER applying this Pull Request
Link to documentations
Please select:
-
Documentation link for docs.joomla.org:
-
No documentation changes for docs.joomla.org needed
-
Pull Request link for manual.joomla.org:
-
No documentation changes for manual.joomla.org needed
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | JavaScript Repository NPM Change |
Remove the old Tags scripts that used it
where
@brianteeman I guess my comment is confusing, I mean there are 2 files (build/media_source/legacy/js/ajax-chosen.es5.js, build/media_source/legacy/js/joomla-chosen.es5.js) that depend on chosen and these are removed. Joomla 4+ doesn't use anywhere chosen thus chosen and the 2 files are removed. Also cleaned up any scripts that had chosen references
I assumed you referred to \build\media_source\system\js\fields\tag.es5.js which appears to use chosen and is not touched by this PR
| Labels |
Added:
NPM Resource Changed
Removal
PR-6.0-dev
|
||
I assumed you referred to \build\media_source\system\js\fields\tag.es5.js
That's the other part of the J3 tags that obviously I missed! Thanks
I have tested this item ✅ successfully on 7b801be
real tests produce real results
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/45018.
| Labels |
Added:
b/c break
Removed: Removal |
||
I have tested this item ✅ successfully on 77d8b3e
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/45018.