Joomla! Issue Tracker - CMS

Download
Launch
Feeling Lucky

[#45017] - [5.4] Cleanup short and sweet script

RTC NPM Resource Changed Enhancement PR-5.4-dev Pending

User tests: Successful: Unsuccessful:

avatar dgrammatiko
dgrammatiko
26 Feb 2025

Pull Request for Issue # .

Summary of Changes

  • Use the JS ESM module instead of the iife
  • Drop the patches in the build tools

Testing Instructions

  • Run npm ci or download and install joomla from the PR
  • Create a new article and check that the Meta Description field (under the publishing tab) updates the remaining characters as you type

Actual result BEFORE applying this Pull Request

Expected result AFTER applying this Pull Request

Link to documentations

Please select:

  • Documentation link for docs.joomla.org:

  • No documentation changes for docs.joomla.org needed

  • Pull Request link for manual.joomla.org:

  • No documentation changes for manual.joomla.org needed

avatar dgrammatiko dgrammatiko - open - 26 Feb 2025
avatar dgrammatiko dgrammatiko - change - 26 Feb 2025
Status New ⇒ Pending
avatar joomla-cms-bot joomla-cms-bot - change - 26 Feb 2025
Category ⇒ JavaScript Repository NPM Change
e1c2d96 26 Feb 2025 avatar dgrammatiko cs
avatar dgrammatiko dgrammatiko - change - 26 Feb 2025
Labels Added: NPM Resource Changed PR-5.3-dev
avatar brianteeman brianteeman - test_item - 6 Mar 2025 - Tested successfully
avatar brianteeman
brianteeman - comment - 6 Mar 2025

I have tested this item ✅ successfully on 756fffe

This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/45017.

avatar dgrammatiko dgrammatiko - change - 6 Mar 2025
The description was changed
avatar dgrammatiko dgrammatiko - edited - 6 Mar 2025
avatar dgrammatiko dgrammatiko - change - 6 Mar 2025
The description was changed
avatar dgrammatiko dgrammatiko - edited - 6 Mar 2025
avatar fgsw fgsw - test_item - 6 Mar 2025 - Tested successfully
avatar fgsw
fgsw - comment - 6 Mar 2025

I have tested this item ✅ successfully on 756fffe

Remaining characters are updated like before.

This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/45017.

avatar Fedik Fedik - change - 6 Mar 2025
Status Pending ⇒ Ready to Commit
avatar Fedik
Fedik - comment - 6 Mar 2025

r2c

This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/45017.

avatar QuyTon QuyTon - change - 6 Mar 2025
Labels Added: Feature RTC Enhancement
avatar rdeutz
rdeutz - comment - 8 Mar 2025

I think it is fine to do this in 5.4, wouldn't do it at this stage in 5.3. It's more a cleanup then a feature but this is up to the ReleaseManager for 5.4. I will rebase it.

avatar rdeutz rdeutz - change - 8 Mar 2025
Title
…
[5.3] Cleanup short and sweet script
[5.4] Cleanup short and sweet script
avatar rdeutz rdeutz - edited - 8 Mar 2025
avatar rdeutz rdeutz - change - 8 Mar 2025
Labels Added: RMDQ PR-5.4-dev
Removed: Feature PR-5.3-dev
avatar joomla-cms-bot joomla-cms-bot - change - 8 Mar 2025
Category JavaScript Repository NPM Change ⇒ Administration com_contact com_newsfeeds Language & Strings JavaScript Repository NPM Change Front End com_users Unit Tests
avatar richard67 richard67 - change - 14 Mar 2025
Labels Added: Unit/System Tests Language Change
avatar joomla-cms-bot joomla-cms-bot - change - 14 Mar 2025
Category JavaScript Repository NPM Change Administration com_contact com_newsfeeds Language & Strings Front End com_users Unit Tests ⇒ JavaScript Repository NPM Change
avatar richard67 richard67 - change - 14 Mar 2025
Status Ready to Commit ⇒ Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 ⇒ 2025-03-14 14:58:27
Closed_By ⇒ richard67
Labels Removed: Unit/System Tests Language Change RMDQ
avatar richard67 richard67 - close - 14 Mar 2025
avatar richard67 richard67 - merge - 14 Mar 2025
avatar richard67
richard67 - comment - 14 Mar 2025

Thanks all.

Add a Comment

Login with GitHub to post a comment