Summary of Changes

Fixing all Joomla backend PHP notices from Cypress test file api/com_media/Files.cy.js and doing some refactoring.

Fixed PHP notices are:

[Sat Feb 22 18:28:44.019593 2025] [php:notice] [pid 31:tid 31] [client 10.0.0.1:64714] PHP Notice:  exif_imagetype(): Error reading from /var/www/html/files/test-image-1.jpg! in /var/www/html/libraries/src/Helper/MediaHelper.php on line 93
[Sat Feb 22 18:28:44.022074 2025] [php:notice] [pid 31:tid 31] [client 10.0.0.1:64714] PHP Notice:  getimagesize(): Error reading from /var/www/html/files/test-image-1.jpg! in /var/www/html/libraries/src/Image/Image.php on line 177
[Sat Feb 22 18:28:44.258619 2025] [php:notice] [pid 31:tid 31] [client 10.0.0.1:64714] PHP Notice:  exif_imagetype(): Error reading from /var/www/html/files/test-dir/test-image-1-subfolder.jpg! in /var/www/html/libraries/src/Helper/MediaHelper.php on line 93
[Sat Feb 22 18:28:44.259092 2025] [php:notice] [pid 31:tid 31] [client 10.0.0.1:64714] PHP Notice:  getimagesize(): Error reading from /var/www/html/files/test-dir/test-image-1-subfolder.jpg! in /var/www/html/libraries/src/Image/Image.php on line 177
[Sat Feb 22 18:28:47.177357 2025] [php:notice] [pid 31:tid 31] [client 10.0.0.1:64714] PHP Notice:  exif_imagetype(): Error reading from /var/www/html/files/test-dir/todelete.jpg! in /var/www/html/libraries/src/Helper/MediaHelper.php on line 93
[Sat Feb 22 18:28:47.178099 2025] [php:notice] [pid 31:tid 31] [client 10.0.0.1:64714] PHP Notice:  getimagesize(): Error reading from /var/www/html/files/test-dir/todelete.jpg! in /var/www/html/libraries/src/Image/Image.php on line 177
[Sat Feb 22 18:28:47.564807 2025] [php:notice] [pid 31:tid 31] [client 10.0.0.1:64714] PHP Notice:  exif_imagetype(): Error reading from /var/www/html/images/test-dir/todelete.jpg! in /var/www/html/libraries/src/Helper/MediaHelper.php on line 93
[Sat Feb 22 18:28:47.565288 2025] [php:notice] [pid 31:tid 31] [client 10.0.0.1:64714] PHP Notice:  getimagesize(): Error reading from /var/www/html/images/test-dir/todelete.jpg! in /var/www/html/libraries/src/Image/Image.php on line 177

All 8 x PHP notices are fixed. Instead of using 1-Byte files, real images are used from Cypress fixtures. Please consider there are still 4 x PHP warning to be fixed (I assume they need to be fixed in PHP API backend code) from api/com_media/Files.cy.js and more warnings and notices are in the overall Joomla System Tests.

And all overwrite files are now created with explicit read-write 0o666, as the default 0o444 creates read-only files, leading to PHP Warnings Failed to open:

[Tue Feb 25 15:40:25.066140 2025] [php:warn] [pid 19962] [client 127.0.0.1:50234] PHP Warning:  file_put_contents(/home/hlu/Desktop/joomla-cms/files/test-dir/override.jpg): Failed to open stream: Permission denied in /home/hlu/Desktop/joomla-cms/libraries/vendor/joomla/filesystem/src/File.php on line 265

Some refactoring:

• Deleted 3 images in tests/System/data/com_media, 2 are not used and Cypress default is to use fixtures folder
• The image file names are counted through and the images show name and path in different colors.
• Second test-dir was named test-dir2 to distinguish clearly.
• afterEach() is reduced to after(), as it is only a clean-up and not needed to execute the tests.
• The last 4 tests can use the prepared files too, as with beforeEach the files are restored before each test.

Testing Instructions

In an Joomla System Tests env run

npx cypress run --spec tests/System/integration/api/com_media/Files.cy.js

Actual result BEFORE applying this Pull Request

Before the patch you see the 8 notices in PHP backend (e.g. on macOS brew installed Apache in file /usr/local/var/log/httpd/error_log).

Note: JBT >= 2.1.21 shows the PHP backend error, warning and notice

Expected result AFTER applying this Pull Request

After installing the PR the notice messages and the overwrite warning messages are gone and the Joomla System Test is still running w/o errors.

Link to documentations

Please select:

• Documentation link for docs.joomla.org:

• No documentation changes for docs.joomla.org needed

• Pull Request link for manual.joomla.org:

• No documentation changes for manual.joomla.org needed