[#44975] - [5.3] Improve api app code using rector rules
- Fixed in Code Base
- 26 Feb 2025
- Medium
- Build: 5.3-dev
- # 44975
- Diff
- joomdonation:api_app_code_improvement
User tests: Successful: Unsuccessful:
Pull Request for Issue # .
Summary of Changes
The api does not contain much code, so I run several rector rules at once (same as the rules I use for components and libraries code) to improve code of our api application. All the changes here are done by rector, no manual change needed.
Turned out, only 3 rules applied:
Testing Instructions
Code review
Actual result BEFORE applying this Pull Request
Works
Expected result AFTER applying this Pull Request
Works, with cleaner code
Link to documentations
Please select:
-
Documentation link for docs.joomla.org:
-
No documentation changes for docs.joomla.org needed
-
Pull Request link for manual.joomla.org:
-
No documentation changes for manual.joomla.org needed
| Status | New | ⇒ | Pending |
sorry for the noise
i've added a reference for myself
I have tested this item ✅ successfully on 96c756e
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/44975.
| Status | Pending | ⇒ | Ready to Commit |
| Labels |
Added:
PR-5.3-dev
|
||
RTC
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/44975.
sorry for the noise i've added a reference for myself
Ah, OK. Thanks
| Labels |
Added:
RTC
|
||
| Status | Ready to Commit | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2025-02-26 18:14:16 |
| Closed_By | ⇒ | HLeithner |
thanks
I have tested this item ✅ successfully on 96c756e
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/44975.