PR-5.2-dev Pending

User tests: Successful: Unsuccessful:

avatar voronkovich
voronkovich
14 Feb 2025

Summary of Changes

Install command hides input when asking for --db-pass and --admin-password values. But it also checks for an option --public_folder which is a typo.

Testing Instructions

  1. Try to install Joomla using CLI:

    php installation/joomla.php install
  2. Ensure that the public folder option appearing as the last question and its value is not hidden.

Actual result BEFORE applying this Pull Request

Expected result AFTER applying this Pull Request

Link to documentations

Please select:

  • Documentation link for docs.joomla.org:

  • No documentation changes for docs.joomla.org needed

  • Pull Request link for manual.joomla.org:

  • No documentation changes for manual.joomla.org needed

avatar voronkovich voronkovich - open - 14 Feb 2025
avatar voronkovich voronkovich - change - 14 Feb 2025
Status New Pending
avatar joomla-cms-bot joomla-cms-bot - change - 14 Feb 2025
Category Installation
avatar dgrammatiko
dgrammatiko - comment - 15 Feb 2025

@voronkovich have you tested installing Joomla from CLI with the interactive version? Is the public folder appearing as the last question after this change?

avatar voronkovich
voronkovich - comment - 15 Feb 2025

@dgrammatiko, I've tested it right now. All works as expected.

avatar richard67
richard67 - comment - 15 Feb 2025

Testing Instructions

I think testing is not needed.

No, sorry. For non trivial PRs which do not just change some comments or so, testing is ALWAYS required, and PR authors are expected to provide testing instructions.

avatar voronkovich voronkovich - change - 15 Feb 2025
The description was changed
avatar voronkovich voronkovich - edited - 15 Feb 2025
avatar voronkovich voronkovich - change - 15 Feb 2025
The description was changed
avatar voronkovich voronkovich - edited - 15 Feb 2025
avatar voronkovich
voronkovich - comment - 15 Feb 2025

@richard67, I've added testing instructions.

avatar voronkovich voronkovich - change - 28 Feb 2025
Labels Added: PR-5.2-dev

Add a Comment

Login with GitHub to post a comment