[#44908] - [5.2][Installation][CLI] Fix hidden option asking
- Pending
- Medium
- Build: 5.2-dev
- # 44908
- Diff
- PopArtDesign:fix-cli-installation-hidden-option-ask
User tests: Successful: 0 Unsuccessful: 0
Summary of Changes
Install command hides input when asking for --db-pass and --admin-password values. But it also checks for an option --public_folder which is a typo.
Testing Instructions
-
Try to install Joomla using CLI:
php installation/joomla.php install
-
Ensure that the public folder option appearing as the last question and its value is not hidden.
Actual result BEFORE applying this Pull Request
Expected result AFTER applying this Pull Request
Link to documentations
Please select:
-
Documentation link for docs.joomla.org:
-
No documentation changes for docs.joomla.org needed
-
Pull Request link for manual.joomla.org:
-
No documentation changes for manual.joomla.org needed
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | Installation |
@dgrammatiko, I've tested it right now. All works as expected.
Testing Instructions
I think testing is not needed.
No, sorry. For non trivial PRs which do not just change some comments or so, testing is ALWAYS required, and PR authors are expected to provide testing instructions.
@richard67, I've added testing instructions.
| Labels |
Added:
PR-5.2-dev
|
||
@voronkovich have you tested installing Joomla from CLI with the interactive version? Is the public folder appearing as the last question after this change?