RTC Code Review PR-5.4-dev Pending

User tests: Successful: Unsuccessful:

avatar Hackwar
Hackwar
14 Feb 2025

Summary of Changes

The UCM system was added in Joomla 3.2.0 and already at that time had major flaws. In 12 years of development, it hasn't been extended in any way and instead we've rather reduced it instead. (The content versioning was a part of it and has been made standalone in 4.0.) I think it can be said that the concept (which barely exists to start with) has failed and we should remove the remnants of it.
This PR deprecates all UCM classes that I could find. It also removes the code where we are using the UCM classes in a functional way. For the moment it keeps it, where it might be used by third party code to keep it backwards compatible. This means that we keep this code in the batch methods, where $this->contentType and $this->type is set with this code, even though neither of the two attributes are used anywhere. We could remove this in 6.0 and drop everything in 7.0 finally.

Testing Instructions

  • Add and remove tags from a content item like an article and see no change between before and after applying the patch.
  • See the ordering field in forms like from contacts and articles and they also should behave identical between before and after applyting the patch.

Link to documentations

Please select:

  • Documentation link for docs.joomla.org:

  • No documentation changes for docs.joomla.org needed

  • Pull Request link for manual.joomla.org: joomla/Manual#484

  • No documentation changes for manual.joomla.org needed

avatar Hackwar Hackwar - open - 14 Feb 2025
avatar Hackwar Hackwar - change - 14 Feb 2025
Status New Pending
avatar joomla-cms-bot joomla-cms-bot - change - 14 Feb 2025
Category Libraries
avatar rdeutz
rdeutz - comment - 19 Feb 2025

Our Backward Compatibility Policy states: Advice on how to amend code that is currently using an element that is marked as deprecated MUST be added to the documentation.

This is being tackled from the wrong side.

avatar HLeithner HLeithner - change - 7 May 2025
Title
[5.3] Deprecating UCM code
[5.4] Deprecating UCM code
avatar HLeithner HLeithner - edited - 7 May 2025
avatar Hackwar Hackwar - change - 4 Jun 2025
Labels Added: Code Review PR-5.4-dev
avatar Hackwar Hackwar - change - 10 Jun 2025
The description was changed
avatar Hackwar Hackwar - edited - 10 Jun 2025
avatar Hackwar
Hackwar - comment - 12 Jun 2025

The comment from Robert has been adressed with the latest changes. Yes, I still need to add the documentation... Still, it is ready to be tested. :-)

avatar Hackwar Hackwar - change - 17 Jun 2025
The description was changed
avatar Hackwar Hackwar - edited - 17 Jun 2025
avatar Hackwar
Hackwar - comment - 17 Jun 2025

Documentation is also added. Now we need tests. 😃

avatar exlemor exlemor - test_item - 17 Jun 2025 - Tested successfully
avatar exlemor
exlemor - comment - 17 Jun 2025

I have tested this item ✅ successfully on bebabfa

I have successfully tested this successfully.

Both the forms and the Tags were fine BEFORE and AFTER. For the tags, I had 1st level tags, some assigned to both languages, some assigned to only one language, and some 3 levels down in a Tag --> Sub-Tag --> Sub-Sub-Tag.


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/44910.

avatar dautrich dautrich - test_item - 17 Jun 2025 - Tested successfully
avatar dautrich
dautrich - comment - 17 Jun 2025

I have tested this item ✅ successfully on bebabfa


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/44910.

avatar richard67 richard67 - change - 19 Jun 2025
Labels Added: Documentation Required
avatar richard67 richard67 - change - 19 Jun 2025
Status Pending Ready to Commit
Build 5.3-dev 5.4-dev
avatar richard67
richard67 - comment - 19 Jun 2025

RTC


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/44910.

avatar QuyTon QuyTon - change - 19 Jun 2025
Labels Added: RTC
avatar richard67 richard67 - change - 29 Jun 2025
Status Ready to Commit Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 2025-06-29 15:29:35
Closed_By richard67
Labels Removed: Documentation Required
avatar richard67 richard67 - close - 29 Jun 2025
avatar richard67 richard67 - merge - 29 Jun 2025
avatar richard67
richard67 - comment - 29 Jun 2025

Thanks all (author and testers).

Add a Comment

Login with GitHub to post a comment