[#44905] - [5.4] Remove calls to LegacyPropertyManagementTrait in User class context
- Fixed in Code Base
- 13 Jun 2025
- Medium
- Build: 5.3-dev
- # 44905
- Diff
- Hackwar:5.3-user-propertymanagement
User tests: Successful: Unsuccessful:
Summary of Changes
The LegacyPropertyManagementTrait is deprecated and will be removed most likely in 7.0. Right now it is still used by the User class and this PR removes all cases where this old code is still used in the Joomla core.
Testing Instructions
Testing the change to the UserModel:
- Create a user and login with it
- Go to "Users > Messaging > Private Messages" and send a message to another user.
- See a row for this message in
#__messages - Delete the newly created user and check in `#__messages´ that the row has been deleted.
Testing the change to the RegistrationModel:
- Go to the options of the user component and enable registration on the site if it isn't.
- At the same place enable the need for new users to be activated by admins
- Go to the frontend and go through the registration process, confirm your email and approve the account by an admin
Testing the change to ResetModel:
Go through the process of resetting your password in the frontend
This tests all other changes in this PR as well.
Actual result BEFORE applying this Pull Request
Everything works as expected.
Expected result AFTER applying this Pull Request
Everything still works as before.
Link to documentations
Please select:
-
Documentation link for docs.joomla.org:
-
No documentation changes for docs.joomla.org needed
-
Pull Request link for manual.joomla.org:
-
No documentation changes for manual.joomla.org needed
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | Administration com_users Front End Libraries Plugins |
| Labels |
Added:
Code Review
PR-5.3-dev
|
||
| Title |
|
||||||
| Category | Administration com_users Front End Libraries Plugins | ⇒ | Administration com_installer com_joomlaupdate com_media NPM Change com_users Repository JavaScript Language & Strings Front End Installation |
| Labels |
Added:
Language Change
NPM Resource Changed
PR-5.4-dev
|
||
| Category | Administration com_users Front End com_installer com_joomlaupdate com_media NPM Change Repository JavaScript Language & Strings Installation | ⇒ | Administration com_users Front End Libraries Plugins |
| Labels |
Removed:
Language Change
NPM Resource Changed
PR-5.3-dev
|
||
Done.
I have tested this item ✅ successfully on 9e80962
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/44905.
| Labels |
Removed:
Code Review
|
||
I have tested this item ✅ successfully on 50ef14c
Tested successfully in Joomla 5.4.0-alpha2-dev
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/44905.
I have tested this item ✅ successfully on 50ef14c
I have tested this successfully! Thanks @Hackwar
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/44905.
| Status | Pending | ⇒ | Ready to Commit |
RTC
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/44905.
| Labels |
Added:
RTC
|
||
| Status | Ready to Commit | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2025-06-13 06:49:38 |
| Closed_By | ⇒ | muhme |
Thank you all.
I have tested this item ✅ successfully on dc51c66
Test 1:
- Created new user as admin and send test msg
- Logged in as new user verify msg
- Send msg to Admin
- Log in as admin verify msg
- Delete user verify nothing in inbox
Test 2:
- Log in as admin setup registrations with admin approval.
- Register
- Verify & approve
- Log in as new user
- Log out, request pass change
- Change pass
- Verify log works for new user.
All tested as I expect it to but for the first time I notice that between user verification and admin approval, there is nothing to indicate that verification has been completed by new user or any indication for admin that there is a user awaiting approval by them. Tested same behaviour on J4.
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/44905.
Any reason this is a draft?