[#44903] - [5.3] Category View: Fix meta tag for author
- Fixed in Code Base
- 27 Feb 2025
- Medium
- Build: 5.3-dev
- # 44903
- Diff
- Hackwar:5.3-category-propertytrait
User tests: Successful: Unsuccessful:
Summary of Changes
The com_content category view has code to add the author of the category as an author meta tag. This code does not work and the meta tag is never set for category views. This PR fixes that.
This is the last occurence of usage of the LegacyPropertyManagementTrait for the CategoryNode class in our core code and would then allow us to delete that trait from that class in 6.0.
Testing Instructions
- Create a category and link it in a menu, for example as a blog category view.
- Make sure the option
Author Meta Tagin global configuration of Joomla is enabled. - Visit the category in the frontend and look at the source code.
Actual result BEFORE applying this Pull Request
No author meta tag.
Expected result AFTER applying this Pull Request
A meta tag similar to the following is displayed: <meta name="author" content="John Doe">
Link to documentations
Please select:
-
Documentation link for docs.joomla.org:
-
No documentation changes for docs.joomla.org needed
-
Pull Request link for manual.joomla.org:
-
No documentation changes for manual.joomla.org needed
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | Front End com_content |
This currently just fixes the existing code. Since the same code is in the article view, I would first fix it like that. Moving this to the schema would be out of scope for this PR and also not what I would want to decide here.
I have tested this item ✅ successfully on d5dc55d
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/44903.
I have tested this item ✅ successfully on d5dc55d
Tested successfully that the PR does what it says. However, I'm not sure if I really want to have an author tag in a category blog if the author of the articles is different to the author of the category. But as the intention of existing code obviously was to add that meta tag and just the code was wrong, this PR is right, and anything else is out of scope.
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/44903.
| Status | Pending | ⇒ | Ready to Commit |
| Labels |
Added:
bug
PR-5.3-dev
|
||
RTC
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/44903.
Agree with @bembelimen we should just remove both lines without a replacement.
| Status | Ready to Commit | ⇒ | Pending |
Back to pending due to requested changes.
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/44903.
| Labels |
Added:
Updates Requested
|
||
Ok, done. I removed it entirely.
I have tested this item ✅ successfully on c18d1ee
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/44903.
I have tested this item ✅ successfully on c18d1ee
Test by using custom update server.
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/44903.
| Status | Pending | ⇒ | Ready to Commit |
RTC
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/44903.
RTC
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/44903.
| Labels |
Added:
RTC
Removed: Updates Requested |
||
| Status | Ready to Commit | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2025-02-27 12:37:48 |
| Closed_By | ⇒ | rdeutz |
shouldnt this go in the schema and not the meta now