Code Review Enhancement PR-5.3-dev Pending

User tests: Successful: Unsuccessful:

avatar dgrammatiko
dgrammatiko
12 Feb 2025

Pull Request for Issue # .

Summary of Changes

Testing Instructions

Actual result BEFORE applying this Pull Request

Expected result AFTER applying this Pull Request

Link to documentations

Please select:

  • Documentation link for docs.joomla.org:

  • No documentation changes for docs.joomla.org needed

  • Pull Request link for manual.joomla.org:

  • No documentation changes for manual.joomla.org needed

avatar dgrammatiko dgrammatiko - open - 12 Feb 2025
avatar dgrammatiko dgrammatiko - change - 12 Feb 2025
Status New Pending
avatar joomla-cms-bot joomla-cms-bot - change - 12 Feb 2025
Category JavaScript Repository
avatar laoneo
laoneo - comment - 12 Feb 2025

Can we silence them only for the vendor folder?

avatar dgrammatiko
dgrammatiko - comment - 12 Feb 2025

Can we silence them only for the vendor folder?

Probably, let me check

avatar dgrammatiko dgrammatiko - change - 12 Feb 2025
Labels Added: PR-5.3-dev
2576201 12 Feb 2025 avatar dgrammatiko cs
3d8ab47 12 Feb 2025 avatar dgrammatiko cs
avatar joomla-cms-bot joomla-cms-bot - change - 12 Feb 2025
Category JavaScript Repository Administration com_media NPM Change JavaScript Repository
avatar dgrammatiko dgrammatiko - change - 12 Feb 2025
Labels Added: NPM Resource Changed
avatar laoneo
laoneo - comment - 12 Feb 2025

The vue fixes are handled here #44852.

avatar dgrammatiko
dgrammatiko - comment - 12 Feb 2025

The vue fixes are handled here

I didnt see that PR, will revert

avatar joomla-cms-bot joomla-cms-bot - change - 12 Feb 2025
Category JavaScript Repository Administration com_media NPM Change JavaScript Repository
avatar dgrammatiko dgrammatiko - change - 13 Feb 2025
Labels Removed: NPM Resource Changed
35840ba 15 Feb 2025 avatar dgrammatiko cs
avatar laoneo
laoneo - comment - 17 Feb 2025

Would that mean that when we add a deprecation in one of these files that they are not visible in the build output?

avatar dgrammatiko
dgrammatiko - comment - 17 Feb 2025

The scss files are still visible in the output of the tool, it's just for them we suppress the deprecations logs
Screenshot 2025-02-17 at 11 23 22

avatar dgrammatiko dgrammatiko - change - 27 May 2025
Status Pending Closed
Closed_Date 0000-00-00 00:00:00 2025-05-27 17:35:53
Closed_By dgrammatiko
Labels Added: Code Review Enhancement
avatar dgrammatiko dgrammatiko - close - 27 May 2025

Add a Comment

Login with GitHub to post a comment