RTC Language Change NPM Resource Changed PR-5.3-dev Pending

User tests: Successful: Unsuccessful:

avatar sdwjoomla
sdwjoomla
12 Feb 2025

Summary of Changes

This PR will:

  • add a tour that highlights new features introduced in Joomla 5.3
  • removes the autostart tour of the prior release

Testing Instructions

Download the update package, not the full install as the tour is only available on updates!

It is possible to find the tour in the list of tours at the top of the Joomla dashboard and run it manually.
Make sure you see images when running the tour (on the first step only) and when editing the tour (System -> Manage -> Guided tours).

Actual result BEFORE applying this Pull Request

No tour highlighting new features for Joomla 5.3.

Expected result AFTER applying this Pull Request

The What’s New in Joomla 5.3! tour is available.

whatnew53

Link to documentations

Please select:

  • Documentation link for docs.joomla.org:

  • No documentation changes for docs.joomla.org needed

  • Pull Request link for manual.joomla.org:

  • No documentation changes for manual.joomla.org needed

avatar sdwjoomla sdwjoomla - open - 12 Feb 2025
avatar sdwjoomla sdwjoomla - change - 12 Feb 2025
Status New Pending
avatar joomla-cms-bot joomla-cms-bot - change - 12 Feb 2025
Category SQL Administration com_admin Postgresql Language & Strings Repository NPM Change
avatar brianteeman
brianteeman - comment - 12 Feb 2025

Template Override Plugin Comparison - adds the ability to compare custom plugins to original code

What is this new feature?

avatar sdwjoomla
sdwjoomla - comment - 13 Feb 2025

Template Override Plugin Comparison - adds the ability to compare custom plugins to original code

What is this new feature?

Did I misunderstand #44588?

avatar heelc29
heelc29 - comment - 13 Feb 2025

#44161 have been reverted

avatar brianteeman
brianteeman - comment - 13 Feb 2025

Template Override Plugin Comparison - adds the ability to compare custom plugins to original code

What is this new feature?

Did I misunderstand #44588?

Yes - A better description would be simply

Template Overrides - Adds compare functionality to plugin overrides

However it is a very minor bug fix, not sure it is significant enough to even be mentioned

avatar sdwjoomla
sdwjoomla - comment - 13 Feb 2025

#44161 have been reverted

Ok, we will update the tour

avatar sdwjoomla
sdwjoomla - comment - 13 Feb 2025

Template Override Plugin Comparison - adds the ability to compare custom plugins to original code

What is this new feature?

Did I misunderstand #44588?

Yes - A better description would be simply

Template Overrides - Adds compare functionality to plugin overrides

However it is a very minor bug fix, not sure it is significant enough to even be mentioned

Thanks will discuss with the team

avatar sdwjoomla sdwjoomla - change - 14 Feb 2025
Labels Added: Language Change NPM Resource Changed PR-5.3-dev
avatar brianteeman
brianteeman - comment - 14 Feb 2025

Does the image need to be so big? W: 2396px | H: 1540px

avatar sdwjoomla sdwjoomla - change - 14 Feb 2025
The description was changed
avatar sdwjoomla sdwjoomla - edited - 14 Feb 2025
avatar fgsw fgsw - test_item - 21 Feb 2025 - Tested successfully
avatar fgsw
fgsw - comment - 21 Feb 2025

I have tested this item ✅ successfully on 2567e2d


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/44871.

avatar VaishnaviSidral VaishnaviSidral - test_item - 22 Feb 2025 - Tested unsuccessfully
avatar VaishnaviSidral
VaishnaviSidral - comment - 22 Feb 2025

I have tested this item 🔴 unsuccessfully on 2567e2d

I have tested and not working as expected


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/44871.

avatar fgsw
fgsw - comment - 22 Feb 2025

I have tested and not working as expected

@VaishnaviSidral Please describe what you expect und what is not working so developer know what you mean.

avatar inforaghavms inforaghavms - test_item - 22 Feb 2025 - Tested successfully
avatar inforaghavms
inforaghavms - comment - 22 Feb 2025

I have tested this item ✅ successfully on 2567e2d

Its tested and working fine as expected.


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/44871.

avatar inforaghavms inforaghavms - test_item - 22 Feb 2025 - Tested successfully
avatar inforaghavms
inforaghavms - comment - 22 Feb 2025

I have tested this item ✅ successfully on 2567e2d

Test is working fine as expected.


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/44871.

avatar tecpromotion tecpromotion - change - 22 Feb 2025
Status Pending Ready to Commit
avatar tecpromotion
tecpromotion - comment - 22 Feb 2025

RTC


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/44871.

avatar brianteeman
brianteeman - comment - 22 Feb 2025

please update all links to rel='noopener noreferrer'

avatar brianteeman
brianteeman - comment - 22 Feb 2025

using empty paragraphs for spacing is a mis-use of a semantic element and should not be done. If you need extra space then use the existing css classes

avatar sdwjoomla sdwjoomla - change - 23 Feb 2025
Labels Added: RTC
avatar rdeutz
rdeutz - comment - 9 Mar 2025

@sdwjoomla could you make the requested changes as soon as possible, we need to merge this here before 18 March (beta3). Thanks.

avatar richard67
richard67 - comment - 12 Mar 2025

Requested changes have been made, RTC still valid.

avatar bembelimen bembelimen - change - 14 Mar 2025
Status Ready to Commit Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 2025-03-14 11:03:08
Closed_By bembelimen
avatar bembelimen bembelimen - close - 14 Mar 2025
avatar bembelimen bembelimen - merge - 14 Mar 2025
avatar bembelimen
bembelimen - comment - 14 Mar 2025

Thx

Add a Comment

Login with GitHub to post a comment