Feeling Lucky
RTC
PR-5.3-dev
[#44842] - [5.3] Improve System - Page Cache plugin code
- Fixed in Code Base
- 9 Feb 2025
- Medium
- Build: 5.3-dev
- # 44842
- Diff
- joomdonation:improve_system_page_cache
User tests: Successful: Unsuccessful:
Pull Request for Issue # .
Summary of Changes
This PR makes several improvements to System - Page Cache plugin code:
- Use more accurate type for $event parameter
- Declare void return type for event listener methods
- Introduce local variable $app to avoid repeat call to $this->getApplication()
Testing Instructions
- Use Joomla 5.3 nightly build
- Enable System - Page Cache plugin
- Navigate to random pages on frontend of your site
Actual result BEFORE applying this Pull Request
Works
Expected result AFTER applying this Pull Request
Works
Link to documentations
Please select:
-
Documentation link for docs.joomla.org:
-
No documentation changes for docs.joomla.org needed
-
Pull Request link for manual.joomla.org:
-
No documentation changes for manual.joomla.org needed
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | Front End Plugins |
LadySolveig
- comment
- 8 Feb 2025
I have tested this item ✅ successfully on 424e1e9
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/44842.
| Labels |
Added:
RTC
PR-5.3-dev
|
||
LadySolveig
- comment
- 8 Feb 2025
RTC
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/44842.
| Status | Pending | ⇒ | Ready to Commit |
| Status | Ready to Commit | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2025-02-09 09:24:56 |
| Closed_By | ⇒ | laoneo |
laoneo
- comment
- 9 Feb 2025
Thanks!
joomdonation
- comment
- 9 Feb 2025
Thanks all !
I have tested this item ✅ successfully on 424e1e9
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/44842.