User tests: Successful: Unsuccessful:
Pull Request for Issue # .
This PR improves System - Language Filter code:
onPrivacyCollectAdminCapabilities
does not return data properly. It needs to use $event->addResult to return data instead of return command. I will backport this bug fix to 5.2 if requiredWorks
Works, code is better. A small bug is fixed.
Please select:
Documentation link for docs.joomla.org:
No documentation changes for docs.joomla.org needed
Pull Request link for manual.joomla.org:
No documentation changes for manual.joomla.org needed
Status | New | ⇒ | Pending |
Category | ⇒ | Front End Plugins |
Labels |
Added:
PR-5.3-dev
|
Hmm, with this PR applied, all was working during my tests, but I got a PHP warning which I do not get without this PR applied:
PHP Warning: Attempt to read property "sef" on null in /home/richard/lamp/public_html/joomla-cms-5.3-dev/plugins/system/languagefilter/src/Extension/LanguageFilter.php on line 278
I get this when using the button in the backend for going to the frontend or when using the site URL without any language suffix appended, i.e. the pure domain only.
Update: And I get it only when having this PR here applied and in addition PR #44844 for the debug plugin. Weird.
Update: Ot happens also when I apply only PR #44844 but not this one here. Will report in PR #44844 .
I have tested this item ✅ successfully on f54e47a
Status | Pending | ⇒ | Ready to Commit |
RTC
Labels |
Added:
Feature
RTC
|
Status | Ready to Commit | ⇒ | Fixed in Code Base |
Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2025-02-09 17:15:14 |
Closed_By | ⇒ | laoneo |
I have tested this item ✅ successfully on f54e47a
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/44841.