Joomla! Issue Tracker - CMS

Download
Launch
Feeling Lucky

[#44840] - [5.3] Improve System - Additional Accessibility Features code

Feature RTC PR-5.3-dev Pending

User tests: Successful: Unsuccessful:

avatar joomdonation
joomdonation
8 Feb 2025

Pull Request for Issue # .

Summary of Changes

This PR makes small improvement to System - Additional Accessibility Features plugin code:

- Do not pass application object from service provider because the plugin does not need to have it. Plugin can get application directly from $event object. Turned out plugin still need application for language loading

  • Introduce local $language variable to replace repeating call $app->getLanguage()

Testing Instructions

  • Code review
  • Or use Joomla 5.3 nightly build, enable System - Additional Accessibility Features plugin, and check and see that it still works like before.

Link to documentations

Please select:

  • Documentation link for docs.joomla.org:

  • No documentation changes for docs.joomla.org needed

  • Pull Request link for manual.joomla.org:

  • No documentation changes for manual.joomla.org needed

avatar joomdonation joomdonation - open - 8 Feb 2025
avatar joomdonation joomdonation - change - 8 Feb 2025
Status New ⇒ Pending
avatar joomla-cms-bot joomla-cms-bot - change - 8 Feb 2025
Category ⇒ Front End Plugins
e3d577f 8 Feb 2025 avatar joomdonation CS
avatar joomdonation joomdonation - change - 8 Feb 2025
Labels Added: PR-5.3-dev
avatar joomdonation joomdonation - change - 10 Feb 2025
Labels Added: Feature
avatar joomdonation joomdonation - change - 10 Feb 2025
The description was changed
avatar joomdonation joomdonation - edited - 10 Feb 2025
avatar richard67 richard67 - test_item - 10 Feb 2025 - Tested successfully
avatar richard67
richard67 - comment - 10 Feb 2025

I have tested this item ✅ successfully on 94e5c13

This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/44840.

avatar QuyTon QuyTon - test_item - 10 Feb 2025 - Tested successfully
avatar QuyTon
QuyTon - comment - 10 Feb 2025

I have tested this item ✅ successfully on 94e5c13

This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/44840.

avatar QuyTon QuyTon - change - 10 Feb 2025
Status Pending ⇒ Ready to Commit
avatar QuyTon
QuyTon - comment - 10 Feb 2025

RTC

This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/44840.

avatar QuyTon QuyTon - change - 10 Feb 2025
Labels Added: RTC
avatar laoneo laoneo - change - 11 Feb 2025
Status Ready to Commit ⇒ Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 ⇒ 2025-02-11 14:40:26
Closed_By ⇒ laoneo
avatar laoneo laoneo - close - 11 Feb 2025
avatar laoneo laoneo - merge - 11 Feb 2025
avatar laoneo
laoneo - comment - 11 Feb 2025

Thanks!

avatar joomdonation
joomdonation - comment - 11 Feb 2025

Thanks everyone :)

Add a Comment

Login with GitHub to post a comment