User tests: Successful: 0 Unsuccessful: 0
Pull Request for PR #44813
fix language changes in PR #44813
code review
The language strings are not sorted alphabetically.
The language strings are sorted alphabetically.
Please select:
Documentation link for docs.joomla.org:
No documentation changes for docs.joomla.org needed
Pull Request link for manual.joomla.org:
No documentation changes for manual.joomla.org needed
Status | New | ⇒ | Pending |
Category | ⇒ | Administration Language & Strings |
Labels |
Added:
Language Change
PR-5.3-dev
|
Labels |
Added:
Updates Requested
|
Labels |
Removed:
Updates Requested
|
Status | Pending | ⇒ | Fixed in Code Base |
Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2025-02-08 14:05:40 |
Closed_By | ⇒ | richard67 |
Thanks.
This is wrong. Underscore has a higher asci value than all uppercase letters and therefore is always sorted after and not before
This is wrong. Underscore has a higher asci value than all uppercase letters and therefore is always sorted after and not before
@brianteeman Could you make a PR? Was possibly my mistake.
developer.joomla.org: "The strings should be alphabetically ordered using the "Standard Alphabetical Order" and not the "ASCII order". This mostly means here that the underscore is sorted BEFORE the letters."
Well that's what I did with my PR for this PR. I've used notepad++, selected the lines and used line operation "Sort alphabetically ascending, ignore case".
This is wrong. Underscore has a higher asci value than all uppercase letters and therefore is always sorted after and not before
We have this also in other .ini files. Underscore before letters.
Merged by review.