Language Change PR-5.3-dev Pending

User tests: Successful: 0 Unsuccessful: 0

avatar tecpromotion
tecpromotion
7 Feb 2025

Pull Request for PR #44813

Summary of Changes

fix language changes in PR #44813

Testing Instructions

code review

Actual result BEFORE applying this Pull Request

The language strings are not sorted alphabetically.

Expected result AFTER applying this Pull Request

The language strings are sorted alphabetically.

Link to documentations

Please select:

  • Documentation link for docs.joomla.org:

  • No documentation changes for docs.joomla.org needed

  • Pull Request link for manual.joomla.org:

  • No documentation changes for manual.joomla.org needed

avatar tecpromotion tecpromotion - open - 7 Feb 2025
avatar tecpromotion tecpromotion - change - 7 Feb 2025
Status New Pending
avatar joomla-cms-bot joomla-cms-bot - change - 7 Feb 2025
Category Administration Language & Strings
avatar tecpromotion tecpromotion - change - 8 Feb 2025
Labels Added: Language Change PR-5.3-dev
avatar tecpromotion tecpromotion - change - 8 Feb 2025
Labels Added: Updates Requested
avatar richard67 richard67 - change - 8 Feb 2025
Labels Removed: Updates Requested
avatar richard67 richard67 - change - 8 Feb 2025
Status Pending Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 2025-02-08 14:05:40
Closed_By richard67
avatar richard67 richard67 - close - 8 Feb 2025
avatar richard67 richard67 - merge - 8 Feb 2025
avatar richard67
richard67 - comment - 8 Feb 2025

Merged by review.

avatar richard67
richard67 - comment - 8 Feb 2025

Thanks.

avatar brianteeman
brianteeman - comment - 8 Feb 2025

This is wrong. Underscore has a higher asci value than all uppercase letters and therefore is always sorted after and not before

avatar richard67
richard67 - comment - 8 Feb 2025

This is wrong. Underscore has a higher asci value than all uppercase letters and therefore is always sorted after and not before

@brianteeman Could you make a PR? Was possibly my mistake.

avatar fgsw
fgsw - comment - 8 Feb 2025

developer.joomla.org: "The strings should be alphabetically ordered using the "Standard Alphabetical Order" and not the "ASCII order". This mostly means here that the underscore is sorted BEFORE the letters."

avatar richard67
richard67 - comment - 8 Feb 2025

Well that's what I did with my PR for this PR. I've used notepad++, selected the lines and used line operation "Sort alphabetically ascending, ignore case".

avatar chmst
chmst - comment - 8 Feb 2025

This is wrong. Underscore has a higher asci value than all uppercase letters and therefore is always sorted after and not before

We have this also in other .ini files. Underscore before letters.

Add a Comment

Login with GitHub to post a comment