[#44843] - [5.3] Remove useless clone statement
- Fixed in Code Base
- 10 Feb 2025
- Medium
- Build: 5.3-dev
- # 44843
- Diff
- joomdonation:remove_useless_clone
User tests: Successful: Unsuccessful:
Pull Request for Issue # .
Summary of Changes
$this->getTable() always return new table object, so having clone statement here is useless, thus I remove it.
Testing Instructions
- Uses Joomla 5.3 nightly build
- Click on an banner to edit
- Press Save As Copy button in the toolbar
Actual result BEFORE applying this Pull Request
Works
Expected result AFTER applying this Pull Request
Works
Link to documentations
Please select:
-
Documentation link for docs.joomla.org:
-
No documentation changes for docs.joomla.org needed
-
Pull Request link for manual.joomla.org:
-
No documentation changes for manual.joomla.org needed
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | Administration com_banners com_categories com_contact com_fields com_newsfeeds com_workflow |
| Labels |
Added:
PR-5.3-dev
|
||
@fgsw Have you tested as described with an article only? I think the testing instructions are not complete. When checking the modified files I see a bunch of stuff to test, but not articles.
@joomdonation Could you check and if necessary complete your testing instructions?
Have you tested as described with an article only?
@richard67 Yes:
- install Blog Sample Data,
- update via custom server and
- save-as-copy an Article successfully.
@richard67 The change is simple and the same for all other items, so I think just test with article should be enough. Of course maintainer will also review code before merging, so it's OK to just test it with just article.
@richard67 The change is simple and the same for all other items, so I think just test with article should be enough. Of course maintainer will also review code before merging, so it's OK to just test it with just article.
@joomdonation But your PR does not touch the article model.
Banner could be tested, or Category.
Banner could be tested, or Category.
Ah, Yes, sorry. The change to article was made before already https://github.com/joomla/joomla-cms/blob/5.3-dev/administrator/components/com_content/src/Model/ArticleModel.php#L729.
@fgsw Could you please help re-testing with banner? Sorry for the inconvenience.
I have tested this item ✅ successfully on 638d6ea
Test Component "Banner" by using the Prebuilt package as an update via the custom update server.
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/44843.
I have tested this item ✅ successfully on 638d6ea
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/44843.
| Status | Pending | ⇒ | Ready to Commit |
RTC
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/44843.
| Status | Ready to Commit | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2025-02-10 16:18:16 |
| Closed_By | ⇒ | richard67 | |
| Labels |
Added:
RTC
|
||
Thanks everyone !
I have tested this item ✅ successfully on 638d6ea
Test by using the Prebuilt package as an update via the custom update server.
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/44843.