RTC Language Change a11y NPM Resource Changed PR-5.3-dev Pending

User tests: Successful: Unsuccessful:

avatar LadySolveig
LadySolveig
19 Jan 2025

Pull Request followup of #39371 .

All the credits go @JackKellyUK and @dgrammatiko.

Summary of Changes

Update awesomplete package to new version and pass new language for title /aria-label attribute string to initalization.

Testing Instructions

  • Setup Smart Search > Search menu item (Smart Search > Search Suggestions global setting must be enabled)
  • Run axe browser plugin / find awesomplete list ul and check for title / aria-label attribute

Actual result BEFORE applying this Pull Request

No title / aria-label attribute present on Awesomplete list

Expected result AFTER applying this Pull Request

Title attribute present on Awesomplete list

Link to documentations

Please select:

  • Documentation link for docs.joomla.org:

  • No documentation changes for docs.joomla.org needed

  • Pull Request link for manual.joomla.org:

  • No documentation changes for manual.joomla.org needed

ec89bb3 19 Jan 2025 avatar LadySolveig cs
avatar LadySolveig LadySolveig - open - 19 Jan 2025
avatar LadySolveig LadySolveig - change - 19 Jan 2025
Status New Pending
avatar joomla-cms-bot joomla-cms-bot - change - 19 Jan 2025
Category JavaScript Repository NPM Change Front End com_finder Language & Strings Modules
avatar QuyTon QuyTon - test_item - 20 Jan 2025 - Tested successfully
avatar QuyTon
QuyTon - comment - 20 Jan 2025

I have tested this item ✅ successfully on ec89bb3


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/44756.

avatar QuyTon QuyTon - change - 21 Jan 2025
Labels Added: Language Change a11y NPM Resource Changed PR-5.3-dev
avatar QuyTon
QuyTon - comment - 22 Jan 2025

Use Web Developer Tools to inspect the Search Terms field element on the frontend. See aria-label attribute.

Before PR:
44756-reults-list

After PR:
44756-search-results

avatar fgsw fgsw - test_item - 22 Jan 2025 - Tested successfully
avatar fgsw
fgsw - comment - 22 Jan 2025

I have tested this item ✅ successfully on 9a59b04


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/44756.

avatar QuyTon QuyTon - alter_testresult - 22 Jan 2025 - QuyTon: Tested successfully
avatar QuyTon QuyTon - change - 22 Jan 2025
Status Pending Ready to Commit
avatar QuyTon
QuyTon - comment - 22 Jan 2025

RTC


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/44756.

avatar QuyTon QuyTon - change - 22 Jan 2025
Labels Added: RTC
avatar richard67 richard67 - close - 8 Feb 2025
avatar richard67 richard67 - merge - 8 Feb 2025
avatar richard67 richard67 - change - 8 Feb 2025
Status Ready to Commit Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 2025-02-08 10:45:49
Closed_By richard67
avatar richard67
richard67 - comment - 8 Feb 2025

Thanks all who contributed and tested.

Add a Comment

Login with GitHub to post a comment