Composer Dependency Changed PR-5.3-dev Pending

User tests: Successful: Unsuccessful:

avatar Hackwar
Hackwar
19 Jan 2025

Summary of Changes

Since we are using a built-in codestyle, we don't need the dealerdirect/phpcodesniffer-composer-installer package anymore, thus removing this. Since it is part of the dev dependencies, we can remove it whenever we want.

Testing Instructions

Codereview

avatar Hackwar Hackwar - open - 19 Jan 2025
avatar Hackwar Hackwar - change - 19 Jan 2025
Status New Pending
avatar joomla-cms-bot joomla-cms-bot - change - 19 Jan 2025
Category External Library Composer Change
avatar Hackwar Hackwar - change - 25 Jan 2025
Labels Added: Composer Dependency Changed PR-5.3-dev
avatar laoneo
laoneo - comment - 27 Jan 2025

This one here has now a conflict because of #44657.

avatar Hackwar
Hackwar - comment - 27 Jan 2025

I recreated the PR. Should be ready now.

avatar Hackwar Hackwar - change - 2 Feb 2025
Title
[5.3] Updating dealerdirect/phpcodesniffer-composer-installer to 1.0.0
[5.3] Removing dealerdirect/phpcodesniffer-composer-installer entirely
avatar Hackwar Hackwar - edited - 2 Feb 2025
avatar Hackwar Hackwar - change - 2 Feb 2025
The description was changed
avatar Hackwar Hackwar - edited - 2 Feb 2025
avatar Hackwar
Hackwar - comment - 2 Feb 2025

I updated the PR to remove this entirely, since we don't need this dependency at all anymore.

avatar laoneo laoneo - change - 3 Feb 2025
Status Pending Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 2025-02-03 06:41:46
Closed_By laoneo
avatar laoneo laoneo - close - 3 Feb 2025
avatar laoneo laoneo - merge - 3 Feb 2025
avatar laoneo
laoneo - comment - 3 Feb 2025

Thanks!

Add a Comment

Login with GitHub to post a comment