RTC Language Change PR-5.3-dev Pending

User tests: Successful: Unsuccessful:

avatar alikon
alikon
19 Dec 2024

Pull Request for Issue #44465 .

Summary of Changes

added a radio button to Exclude self action to be notificated by mail to yourself (default is no)

Testing Instructions

set Email Notifications under "User Actions Log Options" of a Super User account to "Yes".
choose some events to email

Actual result BEFORE applying this Pull Request

the events are notifiyed via email to yourself too even you do the event

Expected result AFTER applying this Pull Request

you can exclude yourself to be notifiyed by email when you do an event

Link to documentations

Please select:

  • Documentation link for docs.joomla.org:

  • No documentation changes for docs.joomla.org needed

  • Pull Request link for manual.joomla.org:

  • No documentation changes for manual.joomla.org needed

avatar alikon alikon - open - 19 Dec 2024
avatar alikon alikon - change - 19 Dec 2024
Status New Pending
avatar joomla-cms-bot joomla-cms-bot - change - 19 Dec 2024
Category Administration SQL com_admin Postgresql Language & Strings Installation Front End Plugins
avatar alikon alikon - change - 19 Dec 2024
Labels Added: Language Change PR-5.3-dev
95d4ade 19 Dec 2024 avatar alikon cs
avatar alikon alikon - change - 19 Dec 2024
The description was changed
avatar alikon alikon - edited - 19 Dec 2024
avatar Kostelano Kostelano - test_item - 19 Dec 2024 - Tested successfully
avatar Kostelano
Kostelano - comment - 19 Dec 2024

I have tested this item ✅ successfully on 5410245


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/44640.

avatar dautrich dautrich - test_item - 21 Dec 2024 - Tested unsuccessfully
avatar dautrich
dautrich - comment - 21 Dec 2024

I have tested this item 🔴 unsuccessfully on 5410245

The checkbox does work for the super user:

  • with the checkbox set, the super users actions didn't trigger an email.
  • with the checkbox not set, the super user's actions triggered an email.

I also created a user in user group "Administrator". The actions of that user didn't trigger an email if the checkbox was set. These actions could be seen in the User Actions Log.


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/44640.

avatar Kostelano
Kostelano - comment - 21 Dec 2024

Yes, there are problems, I rushed and did not check as deeply as I should have. I apologize.

The first thing that definitely does not work is that once the superuser has enabled the option, he no longer receives emails about the actions of any users, not just his own.

8010e4b 22 Dec 2024 avatar alikon cs
029ad6d 22 Dec 2024 avatar alikon cs
7598ad9 22 Dec 2024 avatar alikon cs
avatar alikon
alikon - comment - 22 Dec 2024

@Kostelano @dautrich thanks for reporting
could you give another round of test ? should be fixed now

avatar Kostelano Kostelano - test_item - 23 Dec 2024 - Tested successfully
avatar Kostelano
Kostelano - comment - 23 Dec 2024

I have tested this item ✅ successfully on 7598ad9

Option disabled
As an admin, I receive all messages about actions by mail + actions of other users

Option enabled
As an admin, I receive by mail all messages about the actions of only other users

Option disabled + new user added as second superadmin
As an admin, I receive all user actions by mail again

Option enabled + new user added as second superadmin
As an admin, I only receive actions of other users by email

etc. I ran through all possible other options/combinations. No deviations were noticed. I am sending a successful test


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/44640.

avatar dautrich dautrich - test_item - 23 Dec 2024 - Tested successfully
avatar dautrich
dautrich - comment - 23 Dec 2024

I have tested this item ✅ successfully on 7598ad9


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/44640.

avatar dautrich
dautrich - comment - 23 Dec 2024

I can confirm @Kostelano's results. Unlike him, I didn't use two Super User accounts, but a Super User and an account with access level Administrator. But I also tested the four cases like he did.

avatar richard67 richard67 - change - 23 Dec 2024
Status Pending Ready to Commit
avatar richard67
richard67 - comment - 23 Dec 2024

RTC


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/44640.

avatar rdeutz rdeutz - change - 7 Jan 2025
Status Ready to Commit Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 2025-01-07 09:58:00
Closed_By rdeutz
Labels Added: RTC
avatar rdeutz rdeutz - close - 7 Jan 2025
avatar rdeutz rdeutz - merge - 7 Jan 2025
avatar rdeutz
rdeutz - comment - 7 Jan 2025

Thanks

Add a Comment

Login with GitHub to post a comment