RTC Unit/System Tests b/c break PR-6.0-dev Pending

User tests: Successful: Unsuccessful:

avatar laoneo
laoneo
19 Dec 2024

Summary of Changes

The JPATH_PLATFORM is not used anymore in the core. This pr moves the definition of it to the compatibility plugin. Extensions should check if _JEXEC exists instead.

Code review.

Link to documentations

Please select:

  • Documentation link for docs.joomla.org:

  • No documentation changes for docs.joomla.org needed

  • Pull Request link for manual.joomla.org: joomla/Manual#348

  • No documentation changes for manual.joomla.org needed

avatar laoneo laoneo - open - 19 Dec 2024
avatar laoneo laoneo - change - 19 Dec 2024
Status New Pending
avatar joomla-cms-bot joomla-cms-bot - change - 19 Dec 2024
Category Repository Libraries Unit Tests
avatar laoneo laoneo - change - 19 Dec 2024
Labels Added: Unit/System Tests PR-6.0-dev
avatar laoneo laoneo - edited - 19 Dec 2024
avatar laoneo laoneo - change - 19 Dec 2024
The description was changed
avatar QuyTon QuyTon - test_item - 19 Jan 2025 - Tested successfully
avatar QuyTon
QuyTon - comment - 19 Jan 2025

I have tested this item ✅ successfully on b7edaa5


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/44638.

avatar laoneo laoneo - change - 23 Jan 2025
Labels Added: b/c break
avatar Bodge-IT Bodge-IT - test_item - 5 Feb 2025 - Tested unsuccessfully
avatar Bodge-IT
Bodge-IT - comment - 5 Feb 2025

I have tested this item 🔴 unsuccessfully on 95b56ba

Applying the patch caused white screen in Patch Tester(4.3.3) component. Everything else frontend, backend worked fine. I could not get any additional logging info from the system.


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/44638.

avatar QuyTon
QuyTon - comment - 5 Feb 2025

@Bodge-IT This has been fixed in PatchTester pending a new release. joomla-extensions/patchtester@07c2890

avatar brianteeman
brianteeman - comment - 5 Feb 2025

@Bodge-IT This has been fixed in PatchTester pending a new release. joomla-extensions/patchtester@07c2890

proof that we're not ready for this pointless change

avatar Bodge-IT Bodge-IT - test_item - 6 Feb 2025 - Tested successfully
avatar Bodge-IT
Bodge-IT - comment - 6 Feb 2025

I have tested this item ✅ successfully on 95b56ba

OK, previous test was actually successful. Tested on joomla-extensions/patchtester@07c2890


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/44638.

avatar HLeithner HLeithner - test_item - 8 Feb 2025 - Tested successfully
avatar HLeithner
HLeithner - comment - 8 Feb 2025

I have tested this item ✅ successfully on ecc5f35

Code review


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/44638.

avatar QuyTon QuyTon - alter_testresult - 9 Feb 2025 - QuyTon: Tested successfully
avatar QuyTon QuyTon - change - 9 Feb 2025
Status Pending Ready to Commit
avatar QuyTon
QuyTon - comment - 9 Feb 2025

RTC


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/44638.

avatar laoneo laoneo - change - 9 Feb 2025
Labels Added: RTC
avatar joomla-cms-bot joomla-cms-bot - change - 9 Feb 2025
Category Repository Libraries Unit Tests Repository Libraries Front End Plugins Unit Tests
avatar laoneo
laoneo - comment - 9 Feb 2025

I'v moved the constant to the compat plugin. @Bodge-IT can you test the patch tester with the old code if it still works?

avatar Bodge-IT Bodge-IT - test_item - 9 Feb 2025 - Tested successfully
avatar Bodge-IT
Bodge-IT - comment - 9 Feb 2025

I have tested this item ✅ successfully on d30e272

Tested successfully after Allon's change, with old unpatched Patch Tester.


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/44638.

avatar laoneo laoneo - change - 10 Feb 2025
Title
[6.0] Remove the JPATH_PLATFORM constant
[6.0] Move the JPATH_PLATFORM constant to the compat plugin
avatar laoneo laoneo - edited - 10 Feb 2025
avatar laoneo laoneo - change - 10 Feb 2025
The description was changed
avatar laoneo laoneo - edited - 10 Feb 2025
033d225 10 Feb 2025 avatar laoneo 7
951742e 10 Feb 2025 avatar laoneo cs
avatar Bodge-IT Bodge-IT - change - 12 Feb 2025
Status Ready to Commit Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 2025-02-12 07:18:47
Closed_By Bodge-IT
avatar Bodge-IT Bodge-IT - close - 12 Feb 2025
avatar Bodge-IT Bodge-IT - merge - 12 Feb 2025

Add a Comment

Login with GitHub to post a comment