[#44641] - [5.3] Apply mail cloaking in finder results
- Fixed in Code Base
- 7 Jan 2025
- Medium
- Build: 5.3-dev
- # 44641
- Diff
- SniperSister:public-finder-cloaking
User tests: Successful: Unsuccessful:
Pull Request for Issue #43749
Summary of Changes
Mail addresses in results in com_finder are currently uncloaked, as they are not passed through the OnContentPrepare event.
This PR adds an event handler for the finder results to the cloaking plugin and ensures that the content plugin group is loaded by com_finder.
Testing Instructions
- Create an article with a searchword, following a a mail address
- Search for the word in com_finder
- Inspect the result using your browser dev tools
Actual result BEFORE applying this Pull Request
Mail address in uncloaked.
Expected result AFTER applying this Pull Request
Mail address is cloaked.
Link to documentations
Please select:
-
Documentation link for docs.joomla.org:
-
[ x] No documentation changes for docs.joomla.org needed
-
Pull Request link for manual.joomla.org:
-
[x ] No documentation changes for manual.joomla.org needed
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | Front End com_finder Plugins |
| Title |
|
||||||
| Labels |
Added:
PR-5.3-dev
|
||
Fair comment. Updated as suggested.
After this: Inspect the result using your browser dev tools I got this result:
I have tested this item ✅ successfully on 1c40e08
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/44641.
I have tested this item ✅ successfully on 1c40e08
Test by using Prebuilt package.
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/44641.
| Status | Pending | ⇒ | Ready to Commit |
RTC
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/44641.
| Labels |
Added:
RTC
|
||
The last commit includes more plugins and is irrelevant for the test results, It would suggest to restore the 2 successful tests.
| Status | Ready to Commit | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2025-01-07 09:59:57 |
| Closed_By | ⇒ | rdeutz |
Thanks
Is it a good idea to import ALL content plugins. Shouldn't it just be the mailcloak plugin