[#44618] - [5.3] Add user argument to perform the cli command with a specific user
- Pending
- Medium
- Build: 5.3-dev
- # 44618
- Diff
- Digital-Peak:cli/user
User tests: Successful: Unsuccessful:
Summary of Changes
Sometimes is a user needed when running console commands. As cli per se doesn't know a user, this pr adds a new user argument, when set, does the console application load a user object before executing the command. The argument has the name --user and accepts either the user id or username.
Testing Instructions without the patch
- Create a user with the username test and a normal password which is not "newpw".
- Change the password of a user with the following command:
php cli/joomla.php user:reset-password --username test --password newpw
Testing Instructions with the patch
- Create a user with the username test and a normal password which is not "newpw".
- Change the password of a user on the console with the new
--userargument (replace manager with a username from your system):
php cli/joomla.php user:reset-password --user manager --username test --password newpw - Login on the front with the username test and password newpw.
Actual result BEFORE applying this Pull Request
The username got changed but no action log entry was made and log in on the front is possible.
Expected result AFTER applying this Pull Request
The username got changed and an action log entry was made for the user manager that he changed the user test and log in on the front is possible.
Link to documentations
Please select:
-
Documentation link for docs.joomla.org:
-
No documentation changes for docs.joomla.org needed
-
Pull Request link for manual.joomla.org:
-
No documentation changes for manual.joomla.org needed
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | Libraries |
Not on cli
Yes, as long as we are still discussing things I will not make more changes
| Labels |
Added:
PR-5.3-dev
|
||
This is what I see before and with the pr. (User 605 is an existing user.)
Is this the exact intention of this pr?
This is correct. But I changed the code and to have a more real world test scenario.
| Category | Libraries | ⇒ | CLI Libraries |
| Labels |
Added:
Feature
|
||
Looks good to me
| Labels |
Added:
Maintainers Checked
|
||
i've made this test from cli
where --user adminnotexists doesn't exist , i think if passed must be checked
the password has been changed successfully
when i checked in the backend action log
it report wrong action and wrong user who peformed the cli command
Added an extra check, so the user will only be loaded when it is not a guest in the console application.
Surely there must be some sort of authentication required