RTC b/c break PR-6.0-dev Pending

User tests: Successful: Unsuccessful:

avatar brianteeman
brianteeman
11 Dec 2024

Updated Pull Request for original PR #33913 .

Summary of Changes

The setSeparator function has not been used in Joomla since the release of 4.0

Testing Instructions

Code review

Link to documentations

Please select:

  • Documentation link for docs.joomla.org:

  • No documentation changes for docs.joomla.org needed

  • Pull Request link for manual.joomla.org: joomla/Manual#346

  • No documentation changes for manual.joomla.org needed

avatar brianteeman brianteeman - open - 11 Dec 2024
avatar brianteeman brianteeman - change - 11 Dec 2024
Status New Pending
avatar joomla-cms-bot joomla-cms-bot - change - 11 Dec 2024
Category Modules Front End
avatar laoneo
laoneo - comment - 12 Dec 2024
avatar fgsw fgsw - test_item - 12 Dec 2024 - Tested successfully
avatar fgsw
fgsw - comment - 12 Dec 2024

I have tested this item ✅ successfully on cf0a43c

Prebuilt package used.


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/44605.

avatar brianteeman brianteeman - change - 12 Dec 2024
The description was changed
avatar brianteeman brianteeman - edited - 12 Dec 2024
avatar brianteeman brianteeman - change - 12 Dec 2024
The description was changed
avatar brianteeman brianteeman - edited - 12 Dec 2024
avatar brianteeman
brianteeman - comment - 12 Dec 2024
avatar alikon
alikon - comment - 17 Dec 2024

setting RTC cause it was successfully tested by @Quy too

avatar alikon alikon - alter_testresult - 17 Dec 2024 - @Quy: Tested successfully
avatar alikon alikon - change - 17 Dec 2024
Status Pending Ready to Commit
avatar alikon
alikon - comment - 17 Dec 2024

RTC


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/44605.

avatar laoneo laoneo - change - 17 Dec 2024
The description was changed
avatar laoneo laoneo - edited - 17 Dec 2024
avatar Bodge-IT Bodge-IT - change - 18 Dec 2024
Labels Added: RTC b/c break PR-6.0-dev
avatar Bodge-IT Bodge-IT - test_item - 18 Dec 2024 - Tested successfully
avatar Bodge-IT
Bodge-IT - comment - 18 Dec 2024

I have tested this item ✅ successfully on 2ca900c

function removed as documented


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/44605.

avatar Bodge-IT Bodge-IT - change - 18 Dec 2024
Status Ready to Commit Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 2024-12-18 09:33:57
Closed_By Bodge-IT
avatar Bodge-IT Bodge-IT - close - 18 Dec 2024
avatar Bodge-IT Bodge-IT - merge - 18 Dec 2024

Add a Comment

Login with GitHub to post a comment