RTC Language Change PBF bug PR-5.3-dev Pending

User tests: Successful: Unsuccessful:

avatar alikon
alikon
11 Dec 2024

Pull Request for Issue #39311 .

must be tested after/with #44587

Summary of Changes

Fine grain the notification email of tasks

Testing Instructions

  • have a scheduled task.

  • Set the task notifications to on and choose usergroups (default is Super User)
    image

  • run the task

Actual result BEFORE applying this Pull Request

All users with receive system emails turned on receive notifications about tasks

Expected result AFTER applying this Pull Request

Only the users with receive system emails turned on and belonging to the group configured for notification will receive the mail

Link to documentations

Please select:

  • Documentation link for docs.joomla.org:

  • No documentation changes for docs.joomla.org needed

  • Pull Request link for manual.joomla.org:

  • No documentation changes for manual.joomla.org needed

avatar alikon alikon - open - 11 Dec 2024
avatar alikon alikon - change - 11 Dec 2024
Status New Pending
avatar joomla-cms-bot joomla-cms-bot - change - 11 Dec 2024
Category Administration Language & Strings Front End Plugins
avatar alikon alikon - change - 11 Dec 2024
The description was changed
avatar alikon alikon - edited - 11 Dec 2024
avatar alikon alikon - change - 11 Dec 2024
The description was changed
avatar alikon alikon - edited - 11 Dec 2024
avatar alikon alikon - change - 8 Jan 2025
Labels Added: Language Change PR-5.3-dev
avatar alikon alikon - change - 9 Jan 2025
The description was changed
avatar alikon alikon - edited - 9 Jan 2025
avatar alikon alikon - change - 9 Jan 2025
Title
task_notification_usergroups
[5.3] fine grain task notification mail
avatar alikon alikon - edited - 9 Jan 2025
e03dbb4 9 Jan 2025 avatar alikon msg
avatar Kostelano
Kostelano - comment - 18 Jan 2025

I added a new user to the Registered group, enabled receiving system notifications by mail, added the Registered group in the task settings for successful execution.

Result: only the superadmin receives notifications by mail. The registered user's mail is silent.

avatar alikon
alikon - comment - 19 Jan 2025

@Kostelano fixed

avatar Kostelano
Kostelano - comment - 19 Jan 2025

This is fixed, yes.

If the user is in two, three, etc. groups and these groups are added to the new task parameters, then notifications come 2, 3, etc. times, the same ones. I'm not sure if this is intended.

Probably, the problem does not look serious considering that usually the recipient of the "task completion report" will be the superadmin or several of the most important users (who will be in 1 group), but it is still worth mentioning.

If this is ok, let me know, I will send a successful test.

avatar alikon
alikon - comment - 19 Jan 2025

good point
now 1 mail per user regardless on how much user groups he/she is in

9ffe02a 19 Jan 2025 avatar alikon cs
avatar Kostelano Kostelano - test_item - 19 Jan 2025 - Tested successfully
avatar Kostelano
Kostelano - comment - 19 Jan 2025

I have tested this item ✅ successfully on 9ffe02a

Now it works as stated, no deviations were noticed


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/44604.

avatar ceus1984 ceus1984 - test_item - 22 Feb 2025 - Tested successfully
avatar ceus1984
ceus1984 - comment - 22 Feb 2025

I have tested this item ✅ successfully on 2a3aa18

Added a task and tested it with two users from different usergroups. Worked ok


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/44604.

avatar crommie crommie - test_item - 22 Feb 2025 - Tested successfully
avatar crommie
crommie - comment - 22 Feb 2025

I have tested this item ✅ successfully on 2a3aa18

Tested on 5.3-dev on the PBF server using patch tester.

Works as described.


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/44604.

avatar alikon alikon - change - 22 Feb 2025
Status Pending Ready to Commit
avatar alikon
alikon - comment - 22 Feb 2025

RTC


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/44604.

avatar webfeuerflo
webfeuerflo - comment - 22 Feb 2025

Tested successfully

avatar Sabine-2023 Sabine-2023 - test_item - 22 Feb 2025 - Tested successfully
avatar Sabine-2023
Sabine-2023 - comment - 22 Feb 2025

I have tested this item ✅ successfully on 2a3aa18

Works as expected. Mails were sent only to the assigned user group after adding patch.


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/44604.

avatar exlemor
exlemor - comment - 22 Feb 2025

During PBF 2025, Martina and I both tested it on Lucushost PBF server #22 and #44 and it failed - we send using PHP Mail and SendMail... without luck

avatar crommie
crommie - comment - 22 Feb 2025

Notifications have to be switched on in the task settings. Maybe you forgot? It's switched off by default for successful tasks.

avatar alikon
alikon - comment - 22 Feb 2025

@exlemor did you switch on notification in case of task success ?
or are you testing a different scenario ?

avatar richard67 richard67 - change - 28 Feb 2025
Labels Added: RTC PBF bug
avatar richard67
richard67 - comment - 28 Feb 2025

I've allowed myself to solver the merge conflict which was caused by PR #44967 ,

avatar richard67
richard67 - comment - 28 Feb 2025

I've allowed myself to solve the merge conflict which was caused by PR #44967 ,

avatar rdeutz rdeutz - close - 28 Feb 2025
avatar rdeutz rdeutz - merge - 28 Feb 2025
avatar rdeutz rdeutz - change - 28 Feb 2025
Status Ready to Commit Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 2025-02-28 16:23:38
Closed_By rdeutz

Add a Comment

Login with GitHub to post a comment