RTC Release Blocker NPM Resource Changed bug PR-5.2-dev Pending

User tests: Successful: Unsuccessful:

avatar rdeutz
rdeutz
28 Nov 2024

Pull Request for Issue #44553 .

Summary of Changes

A check if the tooglebutton is existing was missing

Testing Instructions

Open browser console and go to global configuration and check the console. You will see an error, something like "Uncaught TypeError: can't access property "getAttribute", toggleButton is null ... ".

Actual result BEFORE applying this Pull Request

You are also not able to change the smtp or DB passoword. You get errors in the console.

Expected result AFTER applying this Pull Request

You can change the smtp or DB passoword. You don't get errors in the console (at least not the one from above).

Link to documentations

Please select:

  • Documentation link for docs.joomla.org:

  • No documentation changes for docs.joomla.org needed

  • Pull Request link for manual.joomla.org:

  • No documentation changes for manual.joomla.org needed

avatar rdeutz rdeutz - open - 28 Nov 2024
avatar rdeutz rdeutz - change - 28 Nov 2024
Status New Pending
avatar joomla-cms-bot joomla-cms-bot - change - 28 Nov 2024
Category JavaScript Repository NPM Change
avatar rdeutz
rdeutz - comment - 28 Nov 2024

Change who caused the error: #44362

avatar brianteeman brianteeman - test_item - 28 Nov 2024 - Tested successfully
avatar brianteeman
brianteeman - comment - 28 Nov 2024

I have tested this item ✅ successfully on 6c45ca2


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/44555.

avatar superknutsel superknutsel - test_item - 28 Nov 2024 - Tested successfully
avatar superknutsel
superknutsel - comment - 28 Nov 2024

I have tested this item ✅ successfully on 6c45ca2

Works fine now.


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/44555.

avatar alikon alikon - change - 29 Nov 2024
Status Pending Ready to Commit
avatar alikon
alikon - comment - 29 Nov 2024

RTC


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/44555.

avatar pe7er pe7er - change - 29 Nov 2024
Status Ready to Commit Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 2024-11-29 07:59:58
Closed_By pe7er
Labels Added: RTC Release Blocker NPM Resource Changed bug PR-5.2-dev
avatar pe7er pe7er - close - 29 Nov 2024
avatar pe7er pe7er - merge - 29 Nov 2024
avatar pe7er
pe7er - comment - 29 Nov 2024

Thanks @rdeutz !

avatar Luther-001
Luther-001 - comment - 3 Dec 2024

Hi, I am having the same problem. But I can not ssem to find the file to fix the bug. Can you guide me trough step by step please? Kind regards

avatar ChristineWk
ChristineWk - comment - 5 Dec 2024

@Luther-001
Maybe you could check here: 6c45ca2

Add a Comment

Login with GitHub to post a comment