[#44435] - [5.2] Fix JS CS missing trailing comma
- Fixed in Code Base
- 11 Nov 2024
- Medium
- Build: 5.2-dev
- # 44435
- Diff
- richard67:5.2-dev-fix-js-cs-traling-comma
User tests: Successful: Unsuccessful:
Pull Request for Issue # .
Summary of Changes
This pull request (PR) fixes a small javascript code style error in file "tests/System/plugins/fs.mjs".
Here in the 5.2-dev branch, the linter does not complain about that, so the javascript-cs step passes.
But when doing my upmerge PR #44434 for 5.3-dev I've noticed that the javascript-cs step failed in Drone due to that CS error.
It was introduced with PR #44253 .
Testing Instructions
Check that the javascript-cs passes in Drone for this PR here..
Actual result BEFORE applying this Pull Request
The javascript-cs passes in Drone, but in the 5.3-dev branch it fails without this change.
Expected result AFTER applying this Pull Request
The javascript-cs passes in Drone.
Link to documentations
Please select:
-
Documentation link for docs.joomla.org:
-
No documentation changes for docs.joomla.org needed
-
Pull Request link for manual.joomla.org:
-
No documentation changes for manual.joomla.org needed
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | JavaScript Unit Tests |
| Labels |
Added:
Unit/System Tests
PR-5.2-dev
|
||
| Status | Pending | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2024-11-11 13:53:20 |
| Closed_By | ⇒ | laoneo |
Thank you very much!