Language Change NPM Resource Changed PR-5.3-dev Pending

User tests: Successful: Unsuccessful:

avatar richard67
richard67
11 Nov 2024

Pull Request for Issue # .

Summary of Changes

This pull request (PR) merges the changes from 5.2-dev up into 5.3-dev which have been made since the last upmerge with PR #44367 , which includes the file permissions (mode) changes in the git index of the repository from commit 9b13ba2 .

In addition this PR fixes the javascript-cs step failing in Drone due to a missing trailing comma in file tests/System/plugins/fs.mjs . In the 5.2-dev branch the linter doesn't complain about that, but here it does. I have created PR #44435 for the 5.2-dev branch to fix it there, too, and will later handle the conflict when doing the next upmerge for 5.3-dev.

Testing Instructions

Review. Check the commits of this PR and those in the 5.2-dev branch, and check the code changes and the file permissions (mode) changes in this PR.

Link to documentations

Please select:

  • Documentation link for docs.joomla.org:

  • No documentation changes for docs.joomla.org needed

  • Pull Request link for manual.joomla.org:

  • No documentation changes for manual.joomla.org needed

avatar richard67 richard67 - open - 11 Nov 2024
avatar richard67 richard67 - change - 11 Nov 2024
Status New Pending
avatar joomla-cms-bot joomla-cms-bot - change - 11 Nov 2024
Category Administration com_admin SQL Postgresql com_content com_installer com_menus com_users Language & Strings Templates (admin) JavaScript Repository NPM Change
avatar richard67 richard67 - change - 11 Nov 2024
Labels Added: Language Change NPM Resource Changed PR-5.3-dev
avatar richard67 richard67 - change - 11 Nov 2024
The description was changed
avatar richard67 richard67 - edited - 11 Nov 2024
avatar richard67 richard67 - change - 11 Nov 2024
The description was changed
avatar richard67 richard67 - edited - 11 Nov 2024
avatar richard67 richard67 - change - 11 Nov 2024
The description was changed
avatar richard67 richard67 - edited - 11 Nov 2024
avatar richard67
richard67 - comment - 11 Nov 2024

Changing to draft as the system tests are failing for this PR:

1) Test in frontend that the contact site router
       can process contact without a menu item:

      AssertionError: expected 200 to equal 301
      + expected - actual

      -200
      +301

      at  (webpack://joomla/./tests/System/integration/site/components/com_contact/Router.cy.js:5:35

It seems that the new system tests added to the 5.2-dev branch with PR #44253 need to be adapted to changes in the 5.3-dev branch.

avatar richard67
richard67 - comment - 11 Nov 2024

I was able to fix the failing system test by changing the expected result, but I don't know if that is the right change. Will leave this PR in draft mode until clarified.

avatar LadySolveig LadySolveig - change - 13 Nov 2024
Status Pending Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 2024-11-13 13:43:58
Closed_By LadySolveig
avatar LadySolveig LadySolveig - close - 13 Nov 2024
avatar LadySolveig LadySolveig - merge - 13 Nov 2024
avatar LadySolveig
LadySolveig - comment - 13 Nov 2024

Thank you @richard67

Add a Comment

Login with GitHub to post a comment