[#44369] - New article module from J5.2.0 deactivates sticky header!
- Closed
- 29 Oct 2024
- Medium
- Build: 5.2-dev
- # 44369
After a long search we found out the following:
If you use the new (from J5.2.0) post module and assign it to a module position, the sticky header (which appears when scrolling down with the menu and should always remain visible at the top) is deactivated (bypassed) on this page.
This only happens, however, if you use "Display / Layout / Horizontal" in the settings in the new module. If you switch to "Vertical", the sticky header function is executed again and the header appears on the page when scrolling down.
At first I thought that there was a conflict with Astroid Framework 3.1.6 and Template Two (and other templates designed for it), but now that it's also happening with the Joomshaper Helix Ultimate Framework with the helix ultimate template, I suspect a BUG in the new post module.
What's striking is that it only happens when the display layout is set to horizontal. In this case, the module completely removes the sticky header and deactivates this function. Not good at all...
You're welcome to test it yourself.
What now?
joomla-cms-bot
- | Labels |
Added:
No Code Attached Yet
|
||
| Status | New | ⇒ | Closed |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2024-10-29 16:09:31 |
| Closed_By | ⇒ | drmenzelit |
Unfortunately not, even after the adjustment it doesn't work and the header still disappears.
Did you installed the package from the PR or only the patch? It is a PR where you need to run npm to build the CSS files correctly. If you only change the mod-articles.css it will not work, because the old code is still in the minified version of the file (mod-articles.min.css)
OK. I just made the change as shown in the screenshots.
I'll test the package later.
I can't say yet whether I'll be able to do it today.
Please understand me. I always look for the PR download and it would be nice if we were always given a direct link here.
Is this the link to the PR download and install with Code and download zip?
You can download the package here: https://artifacts.joomla.org/drone/joomla/joomla-cms/5.2-dev/44327/downloads/79997/
Test not successful.
The sticky header not works.
@WM-Loose can you open https://issues.joomla.org/tracker/joomla-cms/44327 and
- login with your github-account
- click button "Test this"
- mark "Tested successfully"
Now the test count as successfull.
Viviana found the problem:
It is due to:
@supports (container-type:inline-size) { div:has(.mod-articles-grid), section:has(.mod-articles-grid) { container-type:inline-size; } }It should actually be like this:
@supports (container-type:inline-size) { div:has(> .mod-articles-grid), section:has(> .mod-articles-grid) { container-type:inline-size; } }i.e. the div or section that has .mod-articles-grid as a direct child must be addressed.