[#44327] - [5.2] Articles Module: Remove unused css + modified container query
- Fixed in Code Base
- 7 Nov 2024
- Medium
- Build: 5.2-dev
- # 44327
- Diff
- drmenzelit:mod-articles-css
User tests: Successful: Unsuccessful:
Additional change to fix #44369
Modified the container query to address the div/section that is direct parent of the module.
Summary of Changes
We removed some code from the Articles Module, but forgot to remove the related css. This PR remove some lines in the css file.
Testing Instructions
Create an articles module.
Checkout the PR and run npm run build:css on your development environment
Expected result AFTER applying this Pull Request
No differences in the styling of the module
Link to documentations
Please select:
-
Documentation link for docs.joomla.org:
-
No documentation changes for docs.joomla.org needed
-
Pull Request link for manual.joomla.org:
-
No documentation changes for manual.joomla.org needed
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | Repository NPM Change |
| Labels |
Added:
NPM Resource Changed
PR-5.2-dev
|
||
| Title |
|
||||||
I have tested this item 🔴 unsuccessfully on f298190
Retested after testing DEV in a wrong installation. Unfortunately the DEV version doesn't work either.
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/44327.
I have tested this item 🔴 unsuccessfully on f298190
Retested after testing DEV in a wrong installation. Unfortunately the DEV version doesn't work either.
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/44327.
I have tested this item ✅ successfully on f298190
It works now with5.2.1-dev+pr.44327
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/44327.
It works now.
Thank you Viviana.
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/44327.
I have tested this item ✅ successfully on f298190
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/44327.
| Status | Pending | ⇒ | Ready to Commit |
RTC
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/44327.
| Labels |
Added:
RTC
|
||
| Status | Ready to Commit | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2024-11-07 09:39:32 |
| Closed_By | ⇒ | pe7er |
Thanks @drmenzelit !
I have tested this item ✅ successfully on 11e8e25
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/44327.