Unit/System Tests PR-5.2-dev Pending

User tests: Successful: Unsuccessful:

avatar richard67
richard67
29 Oct 2024

Pull Request for Issue # .

Summary of Changes

This pull request (PR) changes indentation of a multi-line comment in file tests/System/plugins/db.mjs.

The comment had been added with PR #44092 .

The javascript-cs check in Drone is ok with that comment in the 5.2-dev branch, but when doing the upmerge PR #44367 for the 5.3-dev branch I've noticed that it makes that check in Drone fail on that branch.

The reason for that difference is PR #44296 , which was merged in the 5.3-dev branch and updates our linter commands to support mjs.

I think it should be fixed in the 5.2-dev branch, so I've made this PR here. I will later care for the conflict in my upmerge PR when this one here will be merged before that one.

Testing Instructions

Code review, and check if the javascript-cs step passes in Drone.

Actual result BEFORE applying this Pull Request

The javascript-cs step passes in Drone.

The comment changed by this PR here is 2 spaces more indented than the code blockes above and below.

Expected result AFTER applying this Pull Request

The javascript-cs step still passes in Drone.

Indentation of the comment changed by this PR here is the same as for the code blockes above and below.

Link to documentations

Please select:

  • No documentation changes for docs.joomla.org needed

  • No documentation changes for manual.joomla.org needed

avatar richard67 richard67 - open - 29 Oct 2024
avatar richard67 richard67 - change - 29 Oct 2024
Status New Pending
avatar joomla-cms-bot joomla-cms-bot - change - 29 Oct 2024
Category JavaScript Unit Tests
avatar richard67 richard67 - change - 29 Oct 2024
The description was changed
avatar richard67 richard67 - edited - 29 Oct 2024
avatar richard67 richard67 - change - 29 Oct 2024
The description was changed
avatar richard67 richard67 - edited - 29 Oct 2024
avatar laoneo laoneo - close - 29 Oct 2024
avatar laoneo laoneo - merge - 29 Oct 2024
avatar laoneo laoneo - change - 29 Oct 2024
Status Pending Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 2024-10-29 12:09:49
Closed_By laoneo
Labels Added: Unit/System Tests PR-5.2-dev
avatar laoneo
laoneo - comment - 29 Oct 2024

Thanks!

avatar richard67
richard67 - comment - 29 Oct 2024

Thanks for merging!

Add a Comment

Login with GitHub to post a comment