Joomla! Issue Tracker - CMS

Download
Launch
Feeling Lucky

[#44360] - [5.2] Fix Multilingual Associations Infinite Loop

RTC NPM Resource Changed bug PR-5.2-dev Pending

User tests: Successful: Unsuccessful:

avatar MatMyfta
MatMyfta
27 Oct 2024

Pull Request for Issue #44224

Summary of Changes

This update implements conditional checks to verify the existence of specified variables before accessing or modifying their values. This enhancement prevents potential runtime errors associated with null or undefined variables.

Testing Instructions

Described in the issue

Actual result BEFORE applying this Pull Request

Described in the issue

Expected result AFTER applying this Pull Request

  • Console errors related to variable access will be resolved.
  • The infinite loop that previously caused the administration console to become unresponsive is eliminated.

Link to documentations

Please select:

  • Documentation link for docs.joomla.org:

  • No documentation changes for docs.joomla.org needed

  • Pull Request link for manual.joomla.org:

  • No documentation changes for manual.joomla.org needed

avatar MatMyfta MatMyfta - open - 27 Oct 2024
avatar MatMyfta MatMyfta - change - 27 Oct 2024
Status New ⇒ Pending
avatar joomla-cms-bot joomla-cms-bot - change - 27 Oct 2024
Category ⇒ JavaScript Repository NPM Change
avatar newtastic newtastic - test_item - 28 Oct 2024 - Tested successfully
avatar newtastic
newtastic - comment - 28 Oct 2024

I have tested this item ✅ successfully on 2b457d3

I tested this with J5.2.0 Stable and it works like excepted now!

This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/44360.

avatar fgsw
fgsw - comment - 28 Oct 2024

Test by using prebuilt package:

Uncaught TypeError: n.querySelector(...) is null
    <anonymous> https://j44360:8890/media/com_associations/js/sidebyside.min.js?983476:4
    <anonymous> https://j44360:8890/media/com_associations/js/sidebyside.min.js?983476:4

44360

avatar MatMyfta
MatMyfta - comment - 28 Oct 2024

What prebuilt package are you testing?
The changes are made on the build directory, so all the resources in media have to be rebuild with the new changes.

avatar fgsw
fgsw - comment - 28 Oct 2024

The changes are made on the build directory

Had only looked at the prebuild package at the end of the Pull Request and not at the Directory-Path if it contain build.

Would be better in cases like this to not offer prebuilt packages.

avatar Quy
Quy - comment - 28 Oct 2024

Installed the pre-built package:

44360-multilingual

avatar MatMyfta MatMyfta - change - 29 Oct 2024
Labels Added: NPM Resource Changed bug PR-5.2-dev
avatar Quy
Quy - comment - 30 Oct 2024

Still an issue:

44360-multilingual

avatar Quy
Quy - comment - 31 Oct 2024

44360-multilingual2

avatar Quy Quy - test_item - 7 Nov 2024 - Tested successfully
avatar Quy
Quy - comment - 7 Nov 2024

I have tested this item ✅ successfully on cdad048

This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/44360.

avatar viocassel viocassel - test_item - 10 Nov 2024 - Tested successfully
avatar viocassel
viocassel - comment - 10 Nov 2024

I have tested this item ✅ successfully on cdad048

This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/44360.

avatar richard67 richard67 - change - 10 Nov 2024
Status Pending ⇒ Ready to Commit
avatar richard67
richard67 - comment - 10 Nov 2024

RTC

This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/44360.

avatar Quy Quy - change - 10 Nov 2024
Labels Added: RTC
avatar Hackwar Hackwar - change - 14 Nov 2024
Status Ready to Commit ⇒ Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 ⇒ 2024-11-14 08:17:20
Closed_By ⇒ Hackwar
avatar Hackwar Hackwar - close - 14 Nov 2024
avatar Hackwar Hackwar - merge - 14 Nov 2024
avatar Hackwar
Hackwar - comment - 14 Nov 2024

Thank you for your contribution!

Add a Comment

Login with GitHub to post a comment