Feature RTC PR-5.3-dev Pending

User tests: Successful: Unsuccessful:

avatar Fedik
Fedik
27 Oct 2024

Pull Request for Issue # .

Summary of Changes

I had a request to make form token removable for "Form control fields API" .
So here it is.

Testing Instructions

Edit

// Add form control fields
$this->form
->addControlField('task', '')
->addControlField('return', $input->getBase64('return', ''))
->addControlField('forcedLanguage', $forcedLanguage);

And add :

$this->form->removeControlField('joomla.form.token');

Open Article editing form, and check HTML for the from.
The token should be removed.

Actual result BEFORE applying this Pull Request

Field with token is always rendered.
Screenshot 2024-10-27_11-37-48

Expected result AFTER applying this Pull Request

Field with token is removed.
Screenshot 2024-10-27_11-37-11

Link to documentations

Please select:

  • Documentation link for docs.joomla.org:
  • No documentation changes for docs.joomla.org needed
  • Pull Request link for manual.joomla.org: joomla/Manual#322
  • No documentation changes for manual.joomla.org needed

Reference:

avatar Fedik Fedik - open - 27 Oct 2024
avatar Fedik Fedik - change - 27 Oct 2024
Status New Pending
avatar joomla-cms-bot joomla-cms-bot - change - 27 Oct 2024
Category Libraries
avatar Quy Quy - test_item - 29 Oct 2024 - Tested successfully
avatar Quy
Quy - comment - 29 Oct 2024

I have tested this item ✅ successfully on edc60d5


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/44359.

avatar fgsw fgsw - test_item - 29 Oct 2024 - Tested successfully
avatar fgsw
fgsw - comment - 29 Oct 2024

I have tested this item ✅ successfully on edc60d5


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/44359.

avatar alikon alikon - change - 29 Oct 2024
Status Pending Ready to Commit
avatar alikon
alikon - comment - 29 Oct 2024

RTC


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/44359.

avatar Quy Quy - change - 29 Oct 2024
Labels Added: Feature RTC PR-5.3-dev
avatar HLeithner HLeithner - change - 16 Nov 2024
Status Ready to Commit Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 2024-11-16 16:46:51
Closed_By HLeithner
avatar HLeithner HLeithner - close - 16 Nov 2024
avatar HLeithner HLeithner - merge - 16 Nov 2024

Add a Comment

Login with GitHub to post a comment