[#44358] - [5.2] Catch exception to get the user in the action log model
- Ready to Commit
- Medium
- Build: 5.2-dev
- # 44358
- Diff
- Digital-Peak:actionlog/user
User tests: Successful: Unsuccessful:
Pull Request for Issue #42373.
Summary of Changes
Catches an exception when the user factory is not set in the action log model. This is basically against the principle that we want to have the dependencies injected, but it is good for the transition period till all extensions are up to the new architecture.
Testing Instructions
Happens only on 3rd party extensions, see issue.
Actual result BEFORE applying this Pull Request
Extension produces an error when writing to the action log.
Expected result AFTER applying this Pull Request
Extension works and action log is written to the database.
Link to documentations
Please select:
-
Documentation link for docs.joomla.org:
-
No documentation changes for docs.joomla.org needed
-
Pull Request link for manual.joomla.org:
-
No documentation changes for manual.joomla.org needed
Votes
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | Administration |
| Labels |
Added:
PR-5.2-dev
|
||
| Labels |
Added:
bug
|
||
The finder issue is not addressed by this pr.
The finder issue is not addressed by this pr.
Yes ok. Thks Allon . Can you reopen this one for Finder?
Can anyone test this one "by the boook" Joomla way so its into next release? or by code review bcs Its working now after this fix. Thks.
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/44358.
HLeithner
- | Title |
|
||||||
I have tested this item ✅ successfully on e4a6c79
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/44358.
I have tested this item ✅ successfully on e4a6c79
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/44358.
| Status | Pending | ⇒ | Ready to Commit |
RTC
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/44358.
@ssnobben if you were to mark this as successfully tested, then we could merge this into 5.2.3.
All checks have passed
4 successful checks
@joomla-att01
@joomla-cms-bot
Merging is blocked @Hackwar
The base branch does not allow updates. Learn more about protected branches.
Every PR for the CMS needs 2 successful manual tests. At the time of my comment, I was test 1 and you could have been test 2. Now @viocassel has thankfully tested it. Everything else is not of concern right now.
Thanks @viocassel !
Yes the solution for seems working ok now after this fix the error message gone. Great! This still an issue wihth the Finder plg that have to be disable to though.. Plugin\Finder\Content\Extension\Content::onFinderAfterSave() error #42617 #42617