PR-5.3-dev Pending

User tests: Successful: Unsuccessful:

avatar dgrammatiko
dgrammatiko
17 Oct 2024

Pull Request for Issue # .

Summary of Changes

  • Move tools and source JS to ESM
  • The build/media_source/system/js/joomla-core-loader.mjs file now includes the required css and the related build/media_source/system/scss/joomla-core-loader.scss is deleted

Testing Instructions

You need Git and NPM to test this

Pull the 5.3-dev branch and run:

  • npm install
  • npm run cssversioning
  • npm run gzip
  • npm run versioning
  • Store the media folder somewhere outside of the joomla-cms folder

Pull this PR gh pr checkout 43781 and run:

  • npm install
  • npm run cssversioning
  • npm run gzip
  • npm run versioning
  • Store the media folder somewhere outside of the joomla-cms folder

Compare the two folders. The only difference should be the missing files: media/system/css/joomla-core-loader.css, media/system/css/joomla-core-loader.min.css, media/system/css/joomla-core-loader.min.css.gz

Check the basic backend functionality

Actual result BEFORE applying this Pull Request

Expected result AFTER applying this Pull Request

Link to documentations

Please select:

  • Documentation link for docs.joomla.org:

  • No documentation changes for docs.joomla.org needed

  • Pull Request link for manual.joomla.org:

  • No documentation changes for manual.joomla.org needed

avatar dgrammatiko dgrammatiko - open - 17 Oct 2024
avatar dgrammatiko dgrammatiko - change - 17 Oct 2024
Status New Pending
avatar joomla-cms-bot joomla-cms-bot - change - 17 Oct 2024
Category Repository JavaScript
avatar dgrammatiko dgrammatiko - change - 17 Oct 2024
Labels Added: PR-5.3-dev
5800f30 17 Oct 2024 avatar dgrammatiko esm
avatar bembelimen bembelimen - test_item - 17 Oct 2024 - Tested successfully
avatar bembelimen
bembelimen - comment - 17 Oct 2024

I have tested this item ✅ successfully on 5800f30

Looks good!


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/44296.

avatar LadySolveig LadySolveig - change - 17 Oct 2024
Status Pending Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 2024-10-17 17:02:48
Closed_By LadySolveig
avatar LadySolveig LadySolveig - close - 17 Oct 2024
avatar LadySolveig LadySolveig - merge - 17 Oct 2024
avatar LadySolveig
LadySolveig - comment - 17 Oct 2024

Thank you @dgrammatiko 💚 🚀

Add a Comment

Login with GitHub to post a comment